Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRay bug fixes #11

Merged
merged 1 commit into from
Dec 18, 2024
Merged

XRay bug fixes #11

merged 1 commit into from
Dec 18, 2024

Conversation

mathiaspeters
Copy link
Contributor

No description provided.

mathiaspeters
mathiaspeters commented Dec 13, 2024
View reviewed changes
xray/src/client.rs Outdated Show resolved Hide resolved
tomaszklak
tomaszklak reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@tomaszklak tomaszklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can your remove the png and replace it with mermaid chart?

xray/src/client.rs Outdated Show resolved Hide resolved
tomaszklak
tomaszklak reviewed Dec 17, 2024
View reviewed changes
xray/src/client.rs Outdated Show resolved Hide resolved
@mathiaspeters
Copy link
Contributor Author

Can your remove the png and replace it with mermaid chart?

Fixed. Please have a look

@matislovas
Copy link
Contributor

+1

tomaszklak
tomaszklak approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@tomaszklak tomaszklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mathiaspeters mathiaspeters merged commit ec6f9be into main Dec 18, 2024
24 checks passed
@mathiaspeters mathiaspeters deleted the xray_bug_fixes branch December 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszklak tomaszklak tomaszklak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathiaspeters @matislovas @tomaszklak