LLT-5809 #5
Merged
LLT-5809 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently not using those and they are not tested. If we ever plan to add them back it will be easy to revert this commit. Moreover instead of UnixStream::from_raw_fd most likely UnixListener::from(fd: OwnedFd) should be used.
jjanowsk
force-pushed
the
LLT-5809-socket-reader
branch
from
50631c7 to
173e249
Compare
Allow fwmark to be in the config even on platforms that do not support it. Just ignore it. It is in line with wireguard-go behaviour.
jjanowsk
force-pushed
the
LLT-5809-socket-reader
branch
from
173e249 to
7baabdc
Compare
1. Allow multiple commands in one stream 2. Verify that the command is either get=1\n or set=1\n. Previously any other character in place of newline was accepted. 3. Do not use pop to remove newline character from the input line in set handler. Use trim_end instead to avoid clipping the input itself.
jjanowsk
force-pushed
the
LLT-5809-socket-reader
branch
from
9e8e367 to
762ddf3
Compare
tomasz-grz
reviewed
Dec 3, 2024
dfetti
reviewed
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup of UAPI handler. Details in commit messages.