Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to generated code #5

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add docstrings to generated code #5

merged 2 commits into from
Nov 29, 2023

Conversation

Lipt0nas
Copy link
Member

No description provided.

Signed-off-by: Martynas Gurskas <martynas.gurskas@nordsec.com>
@Lipt0nas Lipt0nas requested a review from arg0d November 28, 2023 10:42
Copy link
Contributor

@arg0d arg0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cpp-tests/tests/uniffi_docstring/main.cpp Show resolved Hide resolved
Instead of checking if a given set of docstrings exits, instead parse all present docstrings
and verify that there is no more or no less than the expected entries

Signed-off-by: Martynas Gurskas <martynas.gurskas@nordsec.com>
@Lipt0nas Lipt0nas merged commit f47dc47 into main Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants