Fix bytes type #50
Merged
Fix bytes type #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lipt0nas
approved these changes
Nov 14, 2023
|
The separate tests ensures that |
`Type::Bytes` produces incorrect code in the following situations:
- `u8` is not referenced anywhere else in the definition file. This
causes undefined symbol `FfiConverterUint8`.
- `Vec<u8>` is referenced somewhere in the definition file. This causes
duplicate symbol definition for `FfiConverterSequenceUint8`.
To fix this, replace `Type::Bytes` with `Type::Sequence<u8>` in known
types set before rendering `Type.cs`. This ensures that both FFI
converters `FfiConverterSequenceUInt8` and `FfiConverterUInt8` will
be rendered exactly once in `Types.cs`.
arg0d
force-pushed
the
LLT-4526_fix-bytes-type
branch
from
1d198e0 to
81bf26b
Compare
Lipt0nas
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type::Bytesproduces incorrect code in the following situations:u8is not referenced anywhere else in the definition file. This causes undefined symbolFfiConverterUint8.Vec<u8>is referenced somewhere in the definition file. This causes duplicate symbol definition forFfiConverterSequenceUint8.To fix this, replace
Type::ByteswithType::Sequence<u8>in known types set before renderingType.cs. This ensures that both FFI convertersFfiConverterSequenceUInt8andFfiConverterUInt8will be rendered exactly once inTypes.cs.Fixes #49.