Use byte[] for bytes type #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byte[] is the standard type used for IO operations within dotnet ecosystem. Since `bytes` type would normally be used in IO context, representings `bytes` as `List<byte>` was not a good choice. Passing any `byte[]` IO data between C# and Rust would involve an additional copy from `byte[]` to `List<byte>`. Using `byte[]` directly in uniffi bindings removes the need for this extra copy. List of IO classes using `byte[]`: FileStream, BinaryReader, BinaryWriter, MemoryStream, Socket, NetworkStream, GZipStream, DeflareStream, Aes, RSA, SHA256, WebClient, HttpClient.
Lipt0nas
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
byte[] is the standard type used for IO operations within dotnet ecosystem. Since
bytestype would normally be used in IO context, representingsbytesasList<byte>was not a good choice. Passing anybyte[]IO data between C# and Rust would involve an additional copy frombyte[]toList<byte>. Usingbyte[]directly in uniffi bindings removes the need for this extra copy.List of IO classes using
byte[]:FileStream, BinaryReader, BinaryWriter, MemoryStream, Socket, NetworkStream, GZipStream, DeflareStream, Aes, RSA, SHA256, WebClient, HttpClient.