forked from GlitchEnzo/NuGetForUnity
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed checking for packages already installed in Unity
- Loading branch information
Showing
8 changed files
with
143 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| using System.Collections.Generic; | ||
| using System.IO; | ||
| using System.Linq; | ||
|
|
||
| #if UNITY_EDITOR | ||
| using UnityEditor; | ||
| using UnityEditor.Compilation; | ||
| #endif | ||
|
|
||
| namespace NugetForUnity | ||
| { | ||
| /// <summary> | ||
| /// Helper to resolve what libraries are already known / imported by unity. | ||
| /// </summary> | ||
| internal static class UnityPreImportedLibraryResolver | ||
| { | ||
| private static HashSet<string> alreadyImportedLibs; | ||
|
|
||
| private static HashSet<string> alreadyImportedEditorOnlyLibraries; | ||
|
|
||
| /// <summary> | ||
| /// Gets all libraries that are already imported by unity so we shouldn't / don't need to install them as NuGet packages. | ||
| /// </summary> | ||
| /// <returns>A set of all names of libraries that are already imported by unity.</returns> | ||
| internal static HashSet<string> GetAlreadyImportedLibs() | ||
| { | ||
| if (alreadyImportedLibs != null) | ||
| { | ||
| return alreadyImportedLibs; | ||
| } | ||
| #if UNITY_EDITOR | ||
| // Find all the assemblies already installed by NuGetForUnity | ||
| var alreadyInstalledDllFileNames = new HashSet<string>(); | ||
|
|
||
| if (NugetHelper.NugetConfigFile != null && Directory.Exists(NugetHelper.NugetConfigFile.RepositoryPath)) | ||
| { | ||
| alreadyInstalledDllFileNames = new HashSet<string>( | ||
| Directory.EnumerateFiles(NugetHelper.NugetConfigFile.RepositoryPath, "*.dll", SearchOption.AllDirectories) | ||
| .Select(Path.GetFileNameWithoutExtension)); | ||
| } | ||
|
|
||
| // Search the all project assemblies that are not editor only. | ||
| // We only use player assemblies as we don't need to collect UnityEditor assemblies, we don't support installing NuGet packages with reference to UnityEditor. | ||
| #if UNITY_2019_3_OR_NEWER | ||
| const AssembliesType assemblieType = AssembliesType.PlayerWithoutTestAssemblies; | ||
| #else | ||
| const AssembliesType assemblieType = AssembliesType.Player; | ||
| #endif | ||
| var projectAssemblies = CompilationPipeline.GetAssemblies(assemblieType) | ||
| .Where(playerAssembly => playerAssembly.flags != AssemblyFlags.EditorAssembly); | ||
|
|
||
| // Collect all referenced assemblies but exclude all assemblies installed by NuGetForUnity. | ||
| var porojectReferences = projectAssemblies.SelectMany(playerAssembly => playerAssembly.allReferences); | ||
| alreadyImportedLibs = new HashSet<string>( | ||
| porojectReferences.Select(compiledAssemblyReference => Path.GetFileNameWithoutExtension(compiledAssemblyReference)) | ||
| .Where(assemblyName => !alreadyInstalledDllFileNames.Contains(assemblyName))); | ||
|
|
||
| if (PlayerSettings.GetApiCompatibilityLevel(EditorUserBuildSettings.selectedBuildTargetGroup) == ApiCompatibilityLevel.NET_Standard_2_0) | ||
| { | ||
| // mark NuGet packages that contain the .net standard references as already imported | ||
| alreadyImportedLibs.Add("NETStandard.Library"); | ||
| alreadyImportedLibs.Add("Microsoft.NETCore.Platforms"); | ||
| } | ||
|
|
||
| // the compiler / language is available by default | ||
| alreadyImportedLibs.Add("Microsoft.CSharp"); | ||
|
|
||
| var editorOnlyAssemblies = CompilationPipeline.GetAssemblies(AssembliesType.Editor) | ||
| .Where(assembly => assembly.flags == AssemblyFlags.EditorAssembly) | ||
| .ToList(); | ||
| var editorReferences = editorOnlyAssemblies.SelectMany(editorOnlyAssembly => editorOnlyAssembly.allReferences); | ||
| alreadyImportedEditorOnlyLibraries = new HashSet<string>( | ||
| editorReferences.Select(Path.GetFileNameWithoutExtension).Where(assemblyName => !alreadyImportedLibs.Contains(assemblyName))); | ||
|
|
||
| // com.unity.visualscripting uses .net 4.8 so it implicitly has System.CodeDom | ||
| if (!alreadyImportedLibs.Contains("System.CodeDom") && | ||
| editorOnlyAssemblies.Any(editorOnlyAssembly => editorOnlyAssembly.name == "Unity.VisualScripting.Shared.Editor")) | ||
| { | ||
| alreadyImportedEditorOnlyLibraries.Add("System.CodeDom"); | ||
| } | ||
|
|
||
| NugetHelper.LogVerbose("Already imported libs: {0}", string.Join(", ", alreadyImportedLibs)); | ||
| NugetHelper.LogVerbose("Already imported editor only libraries: {0}", string.Join(", ", alreadyImportedEditorOnlyLibraries)); | ||
| #endif | ||
| return alreadyImportedLibs; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| internal static HashSet<string> GetAlreadyImportedEditorOnlyLibraries() | ||
| { | ||
| if (alreadyImportedEditorOnlyLibraries == null) | ||
| { | ||
| GetAlreadyImportedLibs(); | ||
| } | ||
|
|
||
| return alreadyImportedEditorOnlyLibraries; | ||
| } | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
Assets/NuGet/Editor/UnityPreImportedLibraryResolver.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.