Feat: update free space and trigger check on every page write

src/actions/deviceActions.ts

@@ -79,6 +79,7 @@ import { setSpikeFilter as persistSpikeFilter } from '../utils/persistentStore';
 
 let device: null | SerialDevice = null;
 let updateRequestInterval: NodeJS.Timeout | undefined;
+let releaseFileWriteListener: (() => void) | undefined;
 
 export const setupOptions =
     (recordingMode: RecordingMode): AppThunk<RootState, Promise<void>> =>
@@ -99,6 +100,21 @@ export const setupOptions =
                     DataManager().initializeTriggerSession(60);
                     break;
             }
+
+            releaseFileWriteListener?.();
+            releaseFileWriteListener = DataManager().onFileWrite?.(() => {
+                isDiskFull(
+                    getDiskFullTrigger(getState()),
+                    getSessionRootFolder(getState())
+                ).then(isFull => {
+                    if (isFull) {
+                        logger.warn(
+                            'Session stopped. Disk full trigger detected'
+                        );
+                        dispatch(samplingStop());
+                    }
+                });
+            });
         } catch (err) {
             logger.error(err);
         }
@@ -145,6 +161,7 @@ export const samplingStop =
         dispatch(samplingStoppedAction());
         await device.ppkAverageStop();
         stopPreventSleep();
+        releaseFileWriteListener?.();
     };
 
 export const updateSpikeFilter = (): AppThunk<RootState> => (_, getState) => {
@@ -207,7 +224,6 @@ export const open =
         let prevBits = 0;
         let nbSamples = 0;
         let nbSamplesTotal = 0;
-        let lastDiskFullCheck = 0;
 
         const onSample = ({ value, bits }: SampleValues) => {
             const {
@@ -302,24 +318,6 @@ export const open =
                 dispatch(setSavePending(true));
             }
 
-            const shouldCheckDiskFull =
-                performance.now() - lastDiskFullCheck > 10_000;
-
-            if (shouldCheckDiskFull) {
-                lastDiskFullCheck = performance.now();
-                isDiskFull(
-                    getDiskFullTrigger(getState()),
-                    getSessionRootFolder(getState())
-                ).then(isFull => {
-                    if (isFull) {
-                        logger.warn(
-                            'Session stopped. Disk full trigger detected'
-                        );
-                        dispatch(samplingStop());
-                    }
-                });
-            }
-
             const durationInMicroSeconds =
                 convertTimeToSeconds(
                     getState().app.dataLogger.duration,

src/components/SidePanel/StartStop.tsx

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: LicenseRef-Nordic-4-Clause
  */
 
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useRef, useState } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import {
     ConfirmationDialog,
@@ -57,6 +57,8 @@ const calcFileSizeString = (sampleFreq: number, durationSeconds: number) => {
 
 export default () => {
     const dispatch = useDispatch();
+
+    const onWriteListener = useRef<() => void>();
     const scopePane = useSelector(isScopePane);
     const dataLoggerPane = useSelector(isDataLoggerPane);
     const recordingMode = useSelector(getRecordingMode);
@@ -103,8 +105,14 @@ export default () => {
             return;
         }
 
-        dispatch(samplingStart());
         setShowDialog(false);
+        await dispatch(samplingStart());
+        onWriteListener.current?.();
+        onWriteListener.current = DataManager().onFileWrite(() => {
+            getFreeSpace(diskFullTrigger, sessionFolder).then(s => {
+                setFreeSpace(Math.max(0, s));
+            });
+        });
     };
 
     const [freeSpace, setFreeSpace] = useState<number>(0);
@@ -143,6 +151,7 @@ export default () => {
                     stopText="Stop"
                     onClick={async () => {
                         if (samplingRunning) {
+                            onWriteListener.current?.();
                             dispatch(samplingStop());
                             telemetry.sendEvent('StopSampling', {
                                 mode: recordingMode,

src/globals.ts

@@ -392,6 +392,8 @@ export const DataManager = () => ({
             });
         }),
     hasPendingTriggers: () => options.timeReachedTriggers.length > 0,
+    onFileWrite: (listener: () => void) =>
+        options.fileBuffer?.onFileWrite(listener),
 });
 
 /**

src/utils/FileBuffer.ts

@@ -29,6 +29,7 @@ export class FileBuffer {
     #fileBusy = false;
     #beforeUnload: (event: BeforeUnloadEvent) => Promise<void>;
     #bufferingListeners: ((event: Promise<void>) => void)[] = [];
+    #fileWriteListeners: (() => void)[] = [];
     #freePageBuffers: Uint8Array[] = [];
     #bufferingRequests: Promise<void>[] = [];
     #cancelBufferOperations: WeakMap<Promise<void>, AbortController> =
@@ -125,7 +126,10 @@ export class FileBuffer {
                         throw new Error('Invalid File handle');
                     return fs
                         .appendFile(this.#fileHandle, activePage.page)
-                        .finally(resolve);
+                        .finally(() => {
+                            this.#fileWriteListeners.forEach(l => l());
+                            resolve();
+                        });
                 });
             } else {
                 this.fileOperationTasks.push(() => {
@@ -577,4 +581,18 @@ export class FileBuffer {
             }
         };
     }
+
+    onFileWrite(listener: () => void) {
+        this.#fileWriteListeners.push(listener);
+
+        return () => {
+            const index = this.#fileWriteListeners.findIndex(
+                l => l === listener
+            );
+
+            if (index !== -1) {
+                this.#fileWriteListeners.splice(index, 1);
+            }
+        };
+    }
 }