Skip to content

Commit

Permalink
Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kylebonnici committed Apr 4, 2024
1 parent 122836c commit c8ea377
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

- Chart frame trotting for slower machines.
- Clearing session files on close in some special cases.
- When recording indefinitely **Disk full trigger** stop recording when disk
is full
- Behavior of **Disk full trigger** when recording for an indefinite period of
time. It now correctly stops sampling when the disk is full.

## 4.0.0 - 2024-03-13

Expand Down
2 changes: 1 addition & 1 deletion src/actions/deviceActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const setupOptions =
).then(isFull => {
if (isFull) {
logger.warn(
'Session stopped. Disk full trigger detected'
'Session stopped. Disk full trigger value reached.'
);
dispatch(samplingStop());
}
Expand Down
4 changes: 3 additions & 1 deletion src/components/SidePanel/StartStop.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ export default () => {
setFreeSpace(space);

if (space === 0) {
logger.warn('Disk is full. Unable to start new session');
logger.warn(
'Disk is full. Unable to start sampling. Try changing disk full trigger threshold or free disk memory.'
);
setShowDialog(false);
return;
}
Expand Down

0 comments on commit c8ea377

Please sign in to comment.