From c8ea377223e6067aa9e8db3637a871f7ba6ecfe8 Mon Sep 17 00:00:00 2001 From: kylebonnici Date: Thu, 4 Apr 2024 15:21:30 +0200 Subject: [PATCH] Feedback --- Changelog.md | 4 ++-- src/actions/deviceActions.ts | 2 +- src/components/SidePanel/StartStop.tsx | 4 +++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Changelog.md b/Changelog.md index 0944fcc6..95b64a4a 100644 --- a/Changelog.md +++ b/Changelog.md @@ -9,8 +9,8 @@ - Chart frame trotting for slower machines. - Clearing session files on close in some special cases. -- When recording indefinitely **Disk full trigger** stop recording when disk - is full +- Behavior of **Disk full trigger** when recording for an indefinite period of + time. It now correctly stops sampling when the disk is full. ## 4.0.0 - 2024-03-13 diff --git a/src/actions/deviceActions.ts b/src/actions/deviceActions.ts index 4efa68b4..b3851af8 100644 --- a/src/actions/deviceActions.ts +++ b/src/actions/deviceActions.ts @@ -109,7 +109,7 @@ export const setupOptions = ).then(isFull => { if (isFull) { logger.warn( - 'Session stopped. Disk full trigger detected' + 'Session stopped. Disk full trigger value reached.' ); dispatch(samplingStop()); } diff --git a/src/components/SidePanel/StartStop.tsx b/src/components/SidePanel/StartStop.tsx index a81364fd..91ad66ce 100644 --- a/src/components/SidePanel/StartStop.tsx +++ b/src/components/SidePanel/StartStop.tsx @@ -100,7 +100,9 @@ export default () => { setFreeSpace(space); if (space === 0) { - logger.warn('Disk is full. Unable to start new session'); + logger.warn( + 'Disk is full. Unable to start sampling. Try changing disk full trigger threshold or free disk memory.' + ); setShowDialog(false); return; }