New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teacher review, Mathias gauslå CA css and html #2

Open

mathiasg12 wants to merge 2 commits into develop from review

Collaborator

mathiasg12 commented Nov 3, 2022

css and html files for teacher review,

mathiasg12 added 2 commits

November 2, 2022 13:53


          v9.8

fbb9487

checkout button change

v10

cc6125f

fixed header

mathiasg12 requested a review from MJPhillip

November 3, 2022 11:36

MJPhillip commented Nov 3, 2022

Hi Mathias. Thanks. I've recorded a review going over the site and pointing things out. https://www.loom.com/share/c4f567b7c72a4546be0498243c5f39b7

Here are the main points:

The fonts aren't loading, the main issue is their format is "truetype" not "tff"
The site is responsive which is key
Make sure your CSS is DRY
A few validation issues in the HTML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet