Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow-ruktah #455

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

tahsinrukaiya
Copy link

No description provided.

Copy link
Collaborator

@Fermain Fermain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some improvements here, but overall good work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be ignored from git

"sourceType": "module"
},
"rules": {
"no-undef": "off",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you should avoid changing global rules and stick to the overrides instead. These rules are helpful for the normal app code.

@@ -0,0 +1,19 @@
WORKFLOW CA- social media client

Prerequisites Git Node JS VS-code/other compiler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file could use some formatting. I recommend reading about markdown formatting.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore or delete these example files

cy.wait(500);
cy.get("#loginForm button").contains("Login").click();
cy.wait(1000);
cy.get("button.btn-outline-warning").contains("Logout").should("exist");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good idea to check local storage here too

cy.get("#loginForm button").contains("Login").click();
cy.wait(1000);
cy.get("button.btn-outline-warning").contains("Logout").click();
cy.get("#registerForm > div.modal-footer > button.btn-outline-success")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check local storage after logging out

//
//
// -- This is a parent command --
// Cypress.Commands.add('login', (email, password) => { ... })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a key file that you can use to make functions like "login" that you can reuse in your tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants