-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow-ruktah #455
base: master
Are you sure you want to change the base?
Workflow-ruktah #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some improvements here, but overall good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be ignored from git
"sourceType": "module" | ||
}, | ||
"rules": { | ||
"no-undef": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally you should avoid changing global rules and stick to the overrides instead. These rules are helpful for the normal app code.
@@ -0,0 +1,19 @@ | |||
WORKFLOW CA- social media client | |||
|
|||
Prerequisites Git Node JS VS-code/other compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file could use some formatting. I recommend reading about markdown formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ignore or delete these example files
cy.wait(500); | ||
cy.get("#loginForm button").contains("Login").click(); | ||
cy.wait(1000); | ||
cy.get("button.btn-outline-warning").contains("Logout").should("exist"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to check local storage here too
cy.get("#loginForm button").contains("Login").click(); | ||
cy.wait(1000); | ||
cy.get("button.btn-outline-warning").contains("Logout").click(); | ||
cy.get("#registerForm > div.modal-footer > button.btn-outline-success") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check local storage after logging out
// | ||
// | ||
// -- This is a parent command -- | ||
// Cypress.Commands.add('login', (email, password) => { ... }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a key file that you can use to make functions like "login" that you can reuse in your tests.
No description provided.