Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow #481

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Workflow #481

wants to merge 21 commits into from

Conversation

robfil50219
Copy link

No description provided.

Copy link
Author

@robfil50219 robfil50219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing

desc: false
};

// returns the summary table element

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and other files in the coverage folder should have been gitignored.

// please read our getting started guide:
// https://on.cypress.io/introduction-to-cypress

describe('example to-do app', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to this project. Pls, remove it

// https://on.cypress.io/interacting-with-elements

it('.type() - type into a DOM element', () => {
// https://on.cypress.io/type

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as this, remove it


it('pass your own callback function to should()', () => {
// Pass a function to should that can have any number
// of explicit assertions within it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this too

})

describe('.then()', () => {
it('invokes a callback function with the current subject', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it


// clear cookies again after visiting to remove
// any 3rd party cookies picked up such as cloudflare
cy.clearCookies()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this too

})

// Manage HTTP requests in your app

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the test in the 2-advanced-examples should be removed

Copy link

@sulenchy sulenchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robfil50219,

Thanks for pushing this out. Unfortunately, your delivery does not meet the requirements. Apart from the Prettier and ESLint configuration setup, everything else is missing. In line with the marking criteria, here’s what you missed:

The tests are missing—both the unit and e2e tests.
The README file is missing.
Next steps: You will need to resit this CA. In your resit, please ensure that you address the missing aspects mentioned above.

Feel free to contact me if you have any questions.

Abiodun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants