Hamburger menu UI mobile #181
Open
+262
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the `toggleHamburgerMenu` function to handle toggling the hamburger navigation and file menu visibility. - The hamburger button now toggles the visibility of the navigation menu. - The file button toggles the visibility of the file menu and adds/removes an active state. - Added logic to close the menus when clicking outside them.
- Added smooth transitions and hover scaling for buttons. - Increased font size for active buttons with `.active` class.
- Updated styles for a more streamlined and user-friendly design. - To commit this, I had to remove som errors and add closing </div> - // prettier
- Error text in file - from workflow - removed and commited.
✅ Deploy Preview for yeetsheet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Added the background color to zoom - Updated minor elements to prevent any disruption to the md-size.
jonhenrikaavitsland
requested changes
Oct 3, 2024
There was a problem hiding this comment.
@renahashimi I need you to resolve the merge conflicts. Please request a new review when it has been done.
- Changed ID of the mobile navigation div to "mobileNav" // new workflow index.html. - Updated JavaScript to streamline event handling for the hamburger menu and file menu.
jonhenrikaavitsland
requested changes
Oct 7, 2024
There was a problem hiding this comment.
@RamonaXR Can you please fix the conflicts and request my review after
|
@sulenchy The Dev has issues trying to fix the merge conflicts, I was trying to assist but we was never able to solve the conflicts properly. If it is possible with some assistance on this, we would appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary for #156