From 30fd4f5c6034bbf0c5bd7049fec27309d9b6156d Mon Sep 17 00:00:00 2001
From: Dejan Bratic <dejan.bratic@igwplc.com>
Date: Thu, 29 Jun 2023 16:18:01 +0200
Subject: [PATCH] added unit tests for measurement related enum comparisson;

---
 .../MeasurementConversionFactorTests.cs       | 60 +++++++++++++++----
 1 file changed, 48 insertions(+), 12 deletions(-)

diff --git a/tests/Nox.Types.Tests/Common/MeasurementConversionFactorTests.cs b/tests/Nox.Types.Tests/Common/MeasurementConversionFactorTests.cs
index 2af01e4..fa48e1f 100644
--- a/tests/Nox.Types.Tests/Common/MeasurementConversionFactorTests.cs
+++ b/tests/Nox.Types.Tests/Common/MeasurementConversionFactorTests.cs
@@ -1,4 +1,5 @@
-using Nox.Common;
+using FluentAssertions;
+using Nox.Common;
 
 namespace Nox.Types.Tests.Common;
 
@@ -9,7 +10,7 @@ public void MeasurementUnitConverter_GetConversionFactor_FromFootToMeter_Returns
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.Foot, MeasurementTypeUnit.Meter);
 
-        Assert.Equal(0.30480000033, factor.Value);
+        factor.Value.Should().Be(0.30480000033);
     }
 
     [Fact]
@@ -17,7 +18,7 @@ public void MeasurementUnitConverter_GetConversionFactor_FromMeterToFoot_Returns
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.Meter, MeasurementTypeUnit.Foot);
 
-        Assert.Equal(3.28083989142, factor.Value);
+        factor.Value.Should().Be(3.28083989142);
     }
 
     [Fact]
@@ -25,7 +26,7 @@ public void MeasurementUnitConverter_GetConversionFactor_FromKilometerToMile_Ret
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.Kilometer, MeasurementTypeUnit.Mile);
 
-        Assert.Equal(0.62137119102, factor.Value);
+        factor.Value.Should().Be(0.62137119102);
     }
 
     [Fact]
@@ -33,7 +34,7 @@ public void MeasurementUnitConverter_GetConversionFactor_FromMileToKilometer_Ret
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.Mile, MeasurementTypeUnit.Kilometer);
 
-        Assert.Equal(1.60934400315, factor.Value);
+        factor.Value.Should().Be(1.60934400315);
     }
 
     [Fact]
@@ -41,7 +42,7 @@ public void MeasurementUnitConverter_GetConversionFactor_FromSquareFootToSquareM
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.SquareFoot, MeasurementTypeUnit.SquareMeter);
 
-        Assert.Equal(0.09290304, factor.Value);
+        factor.Value.Should().Be(0.09290304);
     }
 
     [Fact]
@@ -49,7 +50,7 @@ public void MeasurementUnitConverter_GetConversionFactor_FromSquareMeterToSquare
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.SquareMeter, MeasurementTypeUnit.SquareFoot);
 
-        Assert.Equal(10.76391042, factor.Value);
+        factor.Value.Should().Be(10.76391042);
     }
 
     [Fact]
@@ -57,16 +58,51 @@ public void MeasurementUnitConverter_GetConversionFactor_WithSameSourceAndTarget
     {
         var factor = new MeasurementConversionFactor(MeasurementTypeUnit.Foot, MeasurementTypeUnit.Foot);
 
-        Assert.Equal(1, factor.Value);
+        factor.Value.Should().Be(1);
     }
 
     [Fact]
     public void MeasurementUnitConverter_GetConversionFactor_WithUnsupportedConversion_ThrowsException()
     {
-        var exception = Assert.Throws<NotImplementedException>(() => _ =
-            new MeasurementConversionFactor(MeasurementTypeUnit.SquareMeter, MeasurementTypeUnit.Meter)
-        );
+        var action = () => new MeasurementConversionFactor(MeasurementTypeUnit.SquareMeter, MeasurementTypeUnit.Meter);
 
-        Assert.Equal("No conversion defined from SquareMeter to Meter.", exception.Message);
+        action.Should().Throw<NotImplementedException>()
+            .WithMessage("No conversion defined from SquareMeter to Meter.");
+    }
+
+    [Fact]
+    public void MeasurementUnitType_Foot_ReturnsSameValueAsLengthTypeUnit()
+    {
+        ((int)MeasurementTypeUnit.Foot).Should().Be((int)LengthTypeUnit.Foot);
+    }
+
+    [Fact]
+    public void MeasurementUnitType_Meter_ReturnsSameValueAsLengthTypeUnit()
+    {
+        ((int)MeasurementTypeUnit.Meter).Should().Be((int)LengthTypeUnit.Meter);
+    }
+
+    [Fact]
+    public void MeasurementUnitType_Kilometer_ReturnsSameValueAsDistanceTypeUnit()
+    {
+        ((int)MeasurementTypeUnit.Kilometer).Should().Be((int)DistanceTypeUnit.Kilometer);
+    }
+
+    [Fact]
+    public void MeasurementUnitType_Mile_ReturnsSameValueAsDistanceTypeUnit()
+    {
+        ((int)MeasurementTypeUnit.Mile).Should().Be((int)DistanceTypeUnit.Mile);
+    }
+
+    [Fact]
+    public void MeasurementUnitType_SquareFoot_ReturnsSameValueAsLengthTypeUnit()
+    {
+        ((int)MeasurementTypeUnit.SquareFoot).Should().Be((int)AreaTypeUnit.SquareFoot);
+    }
+
+    [Fact]
+    public void MeasurementUnitType_SquareMeter_ReturnsSameValueAsLengthTypeUnit()
+    {
+        ((int)MeasurementTypeUnit.SquareMeter).Should().Be((int)AreaTypeUnit.SquareMeter);
     }
 }