This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Feature/currency code #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochar
suggested changes
Jun 27, 2023
rochar
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
You can remove Nox from the class Name
dejobratic
reviewed
Jul 5, 2023
| /// </summary> | ||
| public sealed class CurrencyCode3 : ValueObject<string, CurrencyCode3> | ||
| { | ||
| private readonly string[] CurrencyCodes = Enum.GetNames(typeof(CurrencyCode)); |
There was a problem hiding this comment.
Can we put this as a private readonly static variable? Also, can we rename it using the following convention https://regusit.atlassian.net/wiki/spaces/NOX/pages/3153461266/Coding+Conventions+Styles+and+Guidelines#Private-static-fields ?
dejobratic
reviewed
Jul 5, 2023
| @@ -0,0 +1,53 @@ | |||
| using Nox.Types.Tests.Types; | |||
There was a problem hiding this comment.
Can we write the tests using FluentAssertions, as it was agreed before?
https://regusit.atlassian.net/wiki/spaces/NOX/pages/3153264693/Test+Projects
dejobratic
suggested changes
Jul 5, 2023
|
Nox.Types was merged to Nox.Generator. Because of that this PR cannot be merged, so @denisvieira-dev please create a new PR for this type in Nox.Generator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.