This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/currency code #46
Open
denisvieira-dev
wants to merge
11
commits into
main
Choose a base branch
from
feature/CurrencyCode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b984485
Currency Code
denisvieira-dev 35af5a6
Update name
denisvieira-dev 85eaa0e
Convesion
denisvieira-dev 06c1a12
From
denisvieira-dev 1518979
Regex validation
denisvieira-dev 3213d77
Fix test
denisvieira-dev 721e042
Currency Code validation
denisvieira-dev bf5c404
Code review
denisvieira-dev ed7ff0e
Currency data
denisvieira-dev e96af20
Changing method to be more readable
denisvieira-dev 4fe67db
Change name class
denisvieira-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
using Microsoft.EntityFrameworkCore.Storage.ValueConversion; | ||
|
||
namespace Nox.Types.EntityFramework; | ||
|
||
/// <summary> | ||
/// Class for three-letters currency code (ISO 4217). | ||
/// </summary> | ||
public class CurrencyCode3Converter : ValueConverter<CurrencyCode3, string> | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="CurrencyCode3Converter" /> class. | ||
/// </summary> | ||
public CurrencyCode3Converter() : base(currencyCode3 => currencyCode3.Value, currencyCode3Value => CurrencyCode3.From(currencyCode3Value)) { } | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
using System; | ||
using System.Linq; | ||
|
||
namespace Nox.Types; | ||
|
||
/// <summary> | ||
/// Class for three-letters currency code (ISO 4217). | ||
/// </summary> | ||
public sealed class CurrencyCode3 : ValueObject<string, CurrencyCode3> | ||
{ | ||
private readonly string[] CurrencyCodes = Enum.GetNames(typeof(CurrencyCode)); | ||
|
||
/// <summary> | ||
/// Validates the <see cref="CurrencyCode3"/> object. | ||
/// </summary> | ||
/// <returns>A validation result indicating whether the <see cref="CurrencyCode3"/> object is valid or not.</returns> | ||
internal override ValidationResult Validate() | ||
{ | ||
var result = base.Validate(); | ||
|
||
if (!CurrencyCodes.Contains(Value)) | ||
{ | ||
result.Errors.Add(new ValidationFailure(nameof(Value), $"Could not create a Nox CurrencyCode3 type with unsupported value '{Value}'.")); | ||
} | ||
|
||
return result; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
using System.Collections; | ||
|
||
namespace Nox.Types.Tests.Types; | ||
public class CurrencyCodeData : IEnumerable<object[]> | ||
{ | ||
public IEnumerator<object[]> GetEnumerator() | ||
{ | ||
yield return new object[] { "AED" }; | ||
yield return new object[] { "AFN" }; | ||
yield return new object[] { "ALL" }; | ||
yield return new object[] { "AMD" }; | ||
yield return new object[] { "ANG" }; | ||
yield return new object[] { "AOA" }; | ||
yield return new object[] { "ARS" }; | ||
yield return new object[] { "AUD" }; | ||
yield return new object[] { "AWG" }; | ||
yield return new object[] { "AZN" }; | ||
yield return new object[] { "BAM" }; | ||
yield return new object[] { "BBD" }; | ||
yield return new object[] { "BDT" }; | ||
yield return new object[] { "BGN" }; | ||
yield return new object[] { "BHD" }; | ||
yield return new object[] { "BIF" }; | ||
yield return new object[] { "BMD" }; | ||
yield return new object[] { "BND" }; | ||
yield return new object[] { "BOB" }; | ||
yield return new object[] { "BRL" }; | ||
yield return new object[] { "BSD" }; | ||
yield return new object[] { "BTC" }; | ||
yield return new object[] { "BTN" }; | ||
yield return new object[] { "BWP" }; | ||
yield return new object[] { "BYR" }; | ||
yield return new object[] { "BYN" }; | ||
yield return new object[] { "BZD" }; | ||
yield return new object[] { "CAD" }; | ||
yield return new object[] { "CDF" }; | ||
yield return new object[] { "CHF" }; | ||
yield return new object[] { "CLP" }; | ||
yield return new object[] { "CNY" }; | ||
yield return new object[] { "COP" }; | ||
yield return new object[] { "CRC" }; | ||
yield return new object[] { "CUC" }; | ||
yield return new object[] { "CUP" }; | ||
yield return new object[] { "CVE" }; | ||
yield return new object[] { "CZK" }; | ||
yield return new object[] { "DJF" }; | ||
yield return new object[] { "DKK" }; | ||
yield return new object[] { "DOP" }; | ||
yield return new object[] { "DZD" }; | ||
yield return new object[] { "EGP" }; | ||
yield return new object[] { "ERN" }; | ||
yield return new object[] { "ETB" }; | ||
yield return new object[] { "EUR" }; | ||
yield return new object[] { "FJD" }; | ||
yield return new object[] { "FKP" }; | ||
yield return new object[] { "GBP" }; | ||
yield return new object[] { "GEL" }; | ||
yield return new object[] { "GHS" }; | ||
yield return new object[] { "GIP" }; | ||
yield return new object[] { "GMD" }; | ||
yield return new object[] { "GNF" }; | ||
yield return new object[] { "GTQ" }; | ||
yield return new object[] { "GYD" }; | ||
yield return new object[] { "HKD" }; | ||
yield return new object[] { "HNL" }; | ||
yield return new object[] { "HRK" }; | ||
yield return new object[] { "HTG" }; | ||
yield return new object[] { "HUF" }; | ||
yield return new object[] { "IDR" }; | ||
yield return new object[] { "ILS" }; | ||
yield return new object[] { "INR" }; | ||
yield return new object[] { "IQD" }; | ||
yield return new object[] { "IRR" }; | ||
yield return new object[] { "ISK" }; | ||
yield return new object[] { "JMD" }; | ||
yield return new object[] { "JOD" }; | ||
yield return new object[] { "JPY" }; | ||
yield return new object[] { "KES" }; | ||
yield return new object[] { "KGS" }; | ||
yield return new object[] { "KHR" }; | ||
yield return new object[] { "KMF" }; | ||
yield return new object[] { "KPW" }; | ||
yield return new object[] { "KRW" }; | ||
yield return new object[] { "KWD" }; | ||
yield return new object[] { "KYD" }; | ||
yield return new object[] { "KZT" }; | ||
yield return new object[] { "LAK" }; | ||
yield return new object[] { "LBP" }; | ||
yield return new object[] { "LKR" }; | ||
yield return new object[] { "LRD" }; | ||
yield return new object[] { "LSL" }; | ||
yield return new object[] { "LYD" }; | ||
yield return new object[] { "MAD" }; | ||
yield return new object[] { "MDL" }; | ||
yield return new object[] { "MGA" }; | ||
yield return new object[] { "MKD" }; | ||
yield return new object[] { "MMK" }; | ||
yield return new object[] { "MNT" }; | ||
yield return new object[] { "MOP" }; | ||
yield return new object[] { "MRO" }; | ||
yield return new object[] { "MTL" }; | ||
yield return new object[] { "MUR" }; | ||
yield return new object[] { "MVR" }; | ||
yield return new object[] { "MWK" }; | ||
yield return new object[] { "MXN" }; | ||
yield return new object[] { "MYR" }; | ||
yield return new object[] { "MZN" }; | ||
yield return new object[] { "NAD" }; | ||
yield return new object[] { "NGN" }; | ||
yield return new object[] { "NIO" }; | ||
yield return new object[] { "NOK" }; | ||
yield return new object[] { "NPR" }; | ||
yield return new object[] { "NZD" }; | ||
yield return new object[] { "OMR" }; | ||
yield return new object[] { "PAB" }; | ||
yield return new object[] { "PEN" }; | ||
yield return new object[] { "PGK" }; | ||
yield return new object[] { "PHP" }; | ||
yield return new object[] { "PKR" }; | ||
yield return new object[] { "PLN" }; | ||
yield return new object[] { "PYG" }; | ||
yield return new object[] { "QAR" }; | ||
yield return new object[] { "RON" }; | ||
yield return new object[] { "RSD" }; | ||
yield return new object[] { "RUB" }; | ||
yield return new object[] { "RWF" }; | ||
yield return new object[] { "SAR" }; | ||
yield return new object[] { "SBD" }; | ||
yield return new object[] { "SCR" }; | ||
yield return new object[] { "SDD" }; | ||
yield return new object[] { "SDG" }; | ||
yield return new object[] { "SEK" }; | ||
yield return new object[] { "SGD" }; | ||
yield return new object[] { "SHP" }; | ||
yield return new object[] { "SLL" }; | ||
yield return new object[] { "SOS" }; | ||
yield return new object[] { "SRD" }; | ||
yield return new object[] { "STD" }; | ||
} | ||
|
||
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator(); | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can remove Nox from the class Name |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
using Nox.Types.Tests.Types; | ||
|
||
namespace Nox.Types.Tests; | ||
public class NoxCurrencyCode3Tests | ||
{ | ||
[Theory] | ||
[ClassData(typeof(CurrencyCodeData))] | ||
public void CurrencyCode3_Constructor_ReturnsSameValue_AllCurrencies(string currencyCode3String) | ||
{ | ||
var currencyCode3 = CurrencyCode3.From(currencyCode3String); | ||
|
||
Assert.Equal(currencyCode3String, currencyCode3.Value); | ||
} | ||
|
||
[Fact] | ||
public void CurrencyCode3_Constructor_WithUnsupportedCurrencyCode3_ThrowsValidationException() | ||
{ | ||
var exception = Assert.Throws<TypeValidationException>(() => _ = | ||
CurrencyCode3.From("ABC") | ||
); | ||
|
||
Assert.Equal("Could not create a Nox CurrencyCode3 type with unsupported value 'ABC'.", exception.Errors.First().ErrorMessage); | ||
} | ||
|
||
[Fact] | ||
public void CurrencyCode3_Equality_Tests() | ||
{ | ||
var currencyCode3_1 = CurrencyCode3.From("USD"); | ||
|
||
var currencyCode3_2 = CurrencyCode3.From("USD"); | ||
|
||
Assert.Equal(currencyCode3_1, currencyCode3_2); | ||
} | ||
|
||
[Fact] | ||
public void CurrencyCode3_NotEqual_Tests() | ||
{ | ||
var currencyCode3_1 = CurrencyCode3.From("RWF"); | ||
|
||
var currencyCode3_2 = CurrencyCode3.From("SHP"); | ||
|
||
Assert.NotEqual(currencyCode3_1, currencyCode3_2); | ||
} | ||
|
||
[Fact] | ||
public void CurrencyCode3_ToString_ReturnsString() | ||
{ | ||
var currencyCode3 = CurrencyCode3.From("USD"); | ||
|
||
Assert.Equal("USD", currencyCode3.ToString()); | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this as a private readonly static variable? Also, can we rename it using the following convention https://regusit.atlassian.net/wiki/spaces/NOX/pages/3153461266/Coding+Conventions+Styles+and+Guidelines#Private-static-fields ?