This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Nox types/20 street address #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2023 15:30
rochar
suggested changes
Jun 27, 2023
tests/Nox.Types.Tests/EntityFrameworkTests/Configuration/StreetAddressDbConfiguration.cs
Outdated
Show resolved
Hide resolved
tests/Nox.Types.Tests/EntityFrameworkTests/Models/StreetAddress.cs
Outdated
Show resolved
Hide resolved
Changed properties set.
…treetAddress # Conflicts: # tests/Nox.Types.Tests/EntityFrameworkTests/Configuration/CountryDbConfiguration.cs # tests/Nox.Types.Tests/EntityFrameworkTests/Models/Country.cs # tests/Nox.Types.Tests/EntityFrameworkTests/NoxTypesEntityFrameworkTests.cs
jan-schutte
approved these changes
Jun 29, 2023
rochar
suggested changes
Jun 29, 2023
tests/Nox.Types.Tests/Types/StreetAddress/StreetAddressTests.cs
Outdated
Show resolved
Hide resolved
alexandervlasenko
approved these changes
Jun 29, 2023
…treetAddress # Conflicts: # tests/Nox.Types.Tests/EntityFrameworkTests/Models/Country.cs # tests/Nox.Types.Tests/EntityFrameworkTests/NoxTypesEntityFrameworkTests.cs
rochar
approved these changes
Jul 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented StreetAddress initial changes.
Need to consider:
Format StreetAddress template to use it in ToString() method. It might depend on AllowedAddress format.
Allowed address formats.
Whether it's possible to have just address without Country.
ZipCode - I guess should be introduced as value-object