Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Implemented Length type #63 #68

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Implemented Length type #63 #68

merged 6 commits into from
Jun 30, 2023

Conversation

dejobratic
Copy link
Contributor

@dejobratic dejobratic commented Jun 28, 2023 •
edited
Loading

  • Implemented Length value type with QuantityValue as underlying type.
  • Length can be created from feet and meters.
  • ToString method prints the value and symbol for unit.

rochar
rochar suggested changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@rochar rochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a few comments. we can discuss this if you want

src/Nox.Types/Types/Length/Length.cs Show resolved Hide resolved
src/Nox.Types/Common/MeasurementConversionFactor.cs Outdated Show resolved Hide resolved
src/Nox.Types/Common/MeasurementConversionFactor.cs Show resolved Hide resolved
tests/Nox.Types.Tests/Common/MeasurementConversionFactorTests.cs Outdated Show resolved Hide resolved
@dejobratic dejobratic requested a review from rochar June 29, 2023 10:00
rochar
rochar suggested changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@rochar rochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution. Just a small comment

src/Nox.Types/Common/MeasurementConversionFactor.cs Show resolved Hide resolved
src/Nox.Types/Common/MeasurementConversionFactor.cs Show resolved Hide resolved
tests/Nox.Types.Tests/Types/Length/LengthTests.cs Show resolved Hide resolved
tests/Nox.Types.Tests/Types/Length/LengthTests.cs Show resolved Hide resolved
@dejobratic dejobratic requested a review from rochar June 29, 2023 14:19
@dejobratic dejobratic merged commit d30d73a into main Jun 30, 2023
2 checks passed
@dejobratic dejobratic deleted the feature/length-type branch June 30, 2023 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rochar rochar rochar approved these changes

@alexandervlasenko alexandervlasenko alexandervlasenko approved these changes

@andresharpe andresharpe Awaiting requested review from andresharpe

@jan-schutte jan-schutte Awaiting requested review from jan-schutte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dejobratic @rochar @alexandervlasenko