feat: detox + iOS simulator support (#3)

- allow builds for iOS simulator (no sign required) - support for detox configuration file (to obtain the build command from detox config file) - zip iOS `.app` artifacts to the output folder - rename NITRO_DEPLOY_PATH for NITRO_APP_PATH
Nubescope · Jan 5, 2023 · a86877e · a86877e
1 parent 0ee9227
commit a86877e
Show file tree

Hide file tree

Showing 8 changed files with 311 additions and 304 deletions.
diff --git a/.releaserc.json b/.releaserc.json
@@ -12,7 +12,7 @@
     [
       "@semantic-release/exec",
       {
-        "prepareCmd": "./build-nitro-cli.sh"
+        "prepareCmd": "./node_modules/nitro/packages/cli/scripts/release.sh ./dist-assets"
       }
     ],
     "@semantic-release/commit-analyzer",
@@ -34,7 +34,7 @@
     [
       "@semantic-release/github",
       {
-        "assets": ["dist/**"]
+        "assets": ["dist-assets/**"]
       }
     ]
   ]

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,147 +1,125 @@
 # [4.3.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.2.1...4.3.0) (2022-12-19)
 
-
 ### Features
 
-* add arguments to specify custom s3 cache provider config ([8a9cf9d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/8a9cf9d182dbb02d710c0e5be968c139bfe5660a))
+- add arguments to specify custom s3 cache provider config ([8a9cf9d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/8a9cf9d182dbb02d710c0e5be968c139bfe5660a))
 
 # [4.3.0-beta.1](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.2.1...4.3.0-beta.1) (2022-12-19)
 
-
 ### Features
 
-* add arguments to specify custom s3 cache provider config ([8a9cf9d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/8a9cf9d182dbb02d710c0e5be968c139bfe5660a))
+- add arguments to specify custom s3 cache provider config ([8a9cf9d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/8a9cf9d182dbb02d710c0e5be968c139bfe5660a))
 
 ## [4.2.1](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.2.0...4.2.1) (2022-12-06)
 
-
 ### Bug Fixes
 
-* declare missing system dependency ([2f43fc5](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2f43fc5d8cb86284fdcf7e50471ca900f354cef6))
+- declare missing system dependency ([2f43fc5](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2f43fc5d8cb86284fdcf7e50471ca900f354cef6))
 
 # [4.2.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.1.0...4.2.0) (2022-12-01)
 
-
 ### Bug Fixes
 
-* change website to Github url ([4c9eff3](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/4c9eff32127ae14d9f05b29ab9c79b74a8936bc4))
-
+- change website to Github url ([4c9eff3](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/4c9eff32127ae14d9f05b29ab9c79b74a8936bc4))
 
 ### Features
 
-* add icon and modify metadata ([049fecf](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/049fecfd6039c7075d3ae8a5fbde3fe5a7daaf54))
+- add icon and modify metadata ([049fecf](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/049fecfd6039c7075d3ae8a5fbde3fe5a7daaf54))
 
 # [4.1.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.0.0...4.1.0) (2022-12-01)
 
-
 ### Features
 
-* add missing parameter and default values  ([ed97533](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/ed97533a4cdf415ef583b5de2cfd170650e32750))
+- add missing parameter and default values ([ed97533](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/ed97533a4cdf415ef583b5de2cfd170650e32750))
 
 # [4.0.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/3.0.0...4.0.0) (2022-11-04)
 
-
 ### Features
 
-* point to the latest nitro version ([2af9e0d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2af9e0d22698cf7cd44a26ee4c3513fa41b3803a))
-* update nitro to the latest version ([fcb2504](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/fcb2504ff489c0323cc33353fcea6d8c162db0bf))
-* update to the latest nitro version ([22034bb](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/22034bb75b5073e7d1ec45870efb2961a11d70d4))
-* update to the latest nitro version ([2d12a4a](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2d12a4a9fefaaf534537270a6bb30a57005983a5))
-
+- point to the latest nitro version ([2af9e0d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2af9e0d22698cf7cd44a26ee4c3513fa41b3803a))
+- update nitro to the latest version ([fcb2504](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/fcb2504ff489c0323cc33353fcea6d8c162db0bf))
+- update to the latest nitro version ([22034bb](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/22034bb75b5073e7d1ec45870efb2961a11d70d4))
+- update to the latest nitro version ([2d12a4a](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2d12a4a9fefaaf534537270a6bb30a57005983a5))
 
 ### BREAKING CHANGES
 
-* remove ios prefix
+- remove ios prefix
 
 # [4.0.0-beta.4](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.0.0-beta.3...4.0.0-beta.4) (2022-11-04)
 
-
 ### Features
 
-* update to the latest nitro version ([22034bb](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/22034bb75b5073e7d1ec45870efb2961a11d70d4))
+- update to the latest nitro version ([22034bb](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/22034bb75b5073e7d1ec45870efb2961a11d70d4))
 
 # [4.0.0-beta.3](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.0.0-beta.2...4.0.0-beta.3) (2022-11-04)
 
-
 ### Features
 
-* update to the latest nitro version ([2d12a4a](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2d12a4a9fefaaf534537270a6bb30a57005983a5))
+- update to the latest nitro version ([2d12a4a](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2d12a4a9fefaaf534537270a6bb30a57005983a5))
 
 # [4.0.0-beta.2](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/4.0.0-beta.1...4.0.0-beta.2) (2022-11-04)
 
-
 ### Features
 
-* point to the latest nitro version ([2af9e0d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2af9e0d22698cf7cd44a26ee4c3513fa41b3803a))
+- point to the latest nitro version ([2af9e0d](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/2af9e0d22698cf7cd44a26ee4c3513fa41b3803a))
 
 # [4.0.0-beta.1](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/3.0.0...4.0.0-beta.1) (2022-11-04)
 
-
 ### Features
 
-* update nitro to the latest version ([fcb2504](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/fcb2504ff489c0323cc33353fcea6d8c162db0bf))
-
+- update nitro to the latest version ([fcb2504](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/fcb2504ff489c0323cc33353fcea6d8c162db0bf))
 
 ### BREAKING CHANGES
 
-* remove ios prefix
+- remove ios prefix
 
 # [3.0.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/2.0.0...3.0.0) (2022-10-27)
 
-
 ### Features
 
-* update to the latest nitro version ([d19dae1](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/d19dae151ec3e5a8c467e3c7afbde5fddfae0cfd))
-
+- update to the latest nitro version ([d19dae1](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/d19dae151ec3e5a8c467e3c7afbde5fddfae0cfd))
 
 ### BREAKING CHANGES
 
-* support for api-key and offline license
+- support for api-key and offline license
 
 # [2.0.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/1.2.0...2.0.0) (2022-10-25)
 
-
 ### Features
 
-* improve args ([8179a39](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/8179a398639c669d7734a1ec52e481e1525631e7))
-
+- improve args ([8179a39](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/8179a398639c669d7734a1ec52e481e1525631e7))
 
 ### BREAKING CHANGES
 
-* remove ios prefix to the args
+- remove ios prefix to the args
 
 # [1.2.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/1.1.2...1.2.0) (2022-10-24)
 
-
 ### Features
 
-* add verbose argument ([069d089](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/069d089d7b257bb103e4330ec5ee5055ecbca7db))
-* upgrade nitro version ([b30296c](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/b30296cd136275753d9aaa333b97194d4e973a7f))
+- add verbose argument ([069d089](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/069d089d7b257bb103e4330ec5ee5055ecbca7db))
+- upgrade nitro version ([b30296c](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/b30296cd136275753d9aaa333b97194d4e973a7f))
 
 ## [1.1.2](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/1.1.1...1.1.2) (2022-10-13)
 
-
 ### Bug Fixes
 
-* apktool injection issue ([3b59078](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/3b590780890db9f185fb87db8dd8ed8a21fb625e))
+- apktool injection issue ([3b59078](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/3b590780890db9f185fb87db8dd8ed8a21fb625e))
 
 ## [1.1.1](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/1.1.0...1.1.1) (2022-10-12)
 
-
 ### Bug Fixes
 
-* remove defaults not required ([526207f](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/526207fd7ff8cab64e9893d665857fd3c24f8741))
+- remove defaults not required ([526207f](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/526207fd7ff8cab64e9893d665857fd3c24f8741))
 
 # [1.1.0](https://github.com/nitro-build/bitrise-step-nitro-ios/compare/1.0.0...1.1.0) (2022-10-05)
 
-
 ### Features
 
-* update bitrise stack ([265cdd6](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/265cdd6aaec7e78b866522b4bd8e0321f4b8cd28))
+- update bitrise stack ([265cdd6](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/265cdd6aaec7e78b866522b4bd8e0321f4b8cd28))
 
 # 1.0.0 (2022-09-12)
 
-
 ### Features
 
-* initial commit ([cf56114](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/cf56114a159fb9a69362d2391d5b5fe20182c6d9))
+- initial commit ([cf56114](https://github.com/nitro-build/bitrise-step-nitro-ios/commit/cf56114a159fb9a69362d2391d5b5fe20182c6d9))
diff --git a/README.md b/README.md
@@ -51,6 +51,7 @@ You can also run this step directly with [Bitrise CLI](https://github.com/bitris
 | `pre_install_command` | Run command prior to install project dependencies (e.g. `rm -rf ./some-folder`) |  |  |
 | `pre_build_command` | Run command prior to start building the app (e.g. `yarn tsc && yarn test`) |  |  |
 | `post_build_command` | Run command once build successfully finished (e.g. `yarn publish`) |  |  |
+| `detox_configuration` | Select a device configuration from your defined configurations. |  |  |
 | `output_directory` | The path to the directory where to place all of Nitro's output files |  | `$BITRISE_DEPLOY_DIR` |
 | `entry_file` | The entry file for bundle generation |  | `$ENTRY_FILE` |
 | `verbose` | Enable verbose logs |  | `no` |
@@ -66,8 +67,9 @@ You can also run this step directly with [Bitrise CLI](https://github.com/bitris
 | `NITRO_BUILD_STATUS` | The status of the latest build (success / failure) |
 | `NITRO_OUTPUT_DIR` | The path to the directory where to place all of Nitro's output files |
 | `NITRO_LOGS_PATH` | The full path to access the build log |
-| `NITRO_DEPLOY_PATH` | The full path to access the build artifacts |
 | `NITRO_SUMMARY_PATH` | The full path to access the build summary report |
+| `NITRO_APP_PATH` | The full path to access the iOS package (.app or .ipa) |
+| `NITRO_DEPLOY_PATH` | The full path to access the iOS package (.app or .ipa) |
 </details>
 
 ## 🙋 Contributing

diff --git a/build-nitro-cli.sh b/build-nitro-cli.sh
diff --git a/package.json b/package.json
@@ -1,24 +1,24 @@
 {
   "name": "bitrise-step-nitro-ios",
-  "version": "4.3.0",
+  "version": "4.4.0-beta.9",
   "repository": "git@github.com:nitro-build/bitrise-step-nitro-ios.git",
   "author": "Juan Pablo Garcia <juanpablogarcia@gmail.com>",
   "license": "MIT",
   "scripts": {
     "prepare": "husky install"
   },
   "dependencies": {
-    "@semantic-release/changelog": "6.0.1",
+    "@semantic-release/changelog": "6.0.2",
     "@semantic-release/exec": "6.0.3",
     "@semantic-release/git": "10.0.1",
     "semantic-release": "19.0.5",
-    "nitro": "ssh://git@github.com:nitro-build/nitro.git#0.7.1"
+    "nitro": "ssh://git@github.com:nitro-build/nitro.git#0.8.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "17.1.2",
-    "@commitlint/config-conventional": "17.1.0",
+    "@commitlint/cli": "17.3.0",
+    "@commitlint/config-conventional": "17.3.0",
     "husky": "8.0.1",
-    "prettier": "2.7.1",
+    "prettier": "2.8.1",
     "prettier-plugin-sh": "0.12.8"
   }
 }
diff --git a/step.sh b/step.sh
@@ -174,6 +174,10 @@ fi
 # Advanced
 # --------
 
+if [[ -n ${detox_configuration} ]]; then
+  args+=("--detox-configuration" "${detox_configuration}")
+fi
+
 if [[ -n ${output_directory} ]]; then
   args+=("--output-directory" "${output_directory}")
 fi

diff --git a/step.yml b/step.yml
@@ -219,6 +219,12 @@ inputs:
       is_expand: true
 
   # Advanced
+  - detox_configuration:
+    opts:
+      category: "Advanced"
+      title: "Detox configuration"
+      summary: "Select a device configuration from your defined configurations."
+      is_expand: true
   - output_directory: "$BITRISE_DEPLOY_DIR"
     opts:
       category: "Advanced"
@@ -271,13 +277,18 @@ outputs:
       title: "Build log location"
       summary: "The full path to access the build log"
       description: "The full path to access the build log"
-  - NITRO_DEPLOY_PATH:
-    opts:
-      title: "Build artifacts location"
-      summary: "The full path to access the build artifacts"
-      description: "The full path to access the build artifacts"
   - NITRO_SUMMARY_PATH:
     opts:
       title: "Summary location"
       summary: "The full path to access the build summary report"
       description: "The full path to access the build summary report"
+  - NITRO_APP_PATH:
+    opts:
+      title: "Build application package location"
+      summary: "The full path to access the iOS package (.app or .ipa)"
+      description: "The full path to access the iOS package (.app or .ipa)"
+  - NITRO_DEPLOY_PATH: # deprecated
+    opts:
+      title: "Build application package location"
+      summary: "The full path to access the iOS package (.app or .ipa)"
+      description: "The full path to access the iOS package (.app or .ipa)"