Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a game controller icon for the game portal opener item #199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a game controller icon for the game portal opener item #199

wants to merge 2 commits into from

Conversation

Hugman76
Copy link
Member

No description provided.

haykam821
haykam821 reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@haykam821 haykam821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to use data generation to generate the assets.

@Hugman76
Copy link
Member Author

I believe FAPI's datagen does not support item model definitions that aren't tied to a registered item.

@haykam821
Copy link
Contributor

I believe you're right on that front, since ItemModelOutput#accept requires an item to be passed. In that case, would using the game portal opener itself as the item work? The model wouldn't be referenced anywhere else anyways.

@Hugman76
Copy link
Member Author

Figured something out using Polymer's resource pack extras API :D

@Hugman76 Hugman76 requested a review from haykam821 December 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haykam821 haykam821 Awaiting requested review from haykam821

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hugman76 @haykam821