Skip to content

Commit

Permalink
fix: No html escape in callback arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
Nukesor committed Aug 17, 2024
1 parent afcd28d commit 70cfb6c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
9 changes: 5 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ Upon updating Pueue, the previous state will be wiped, resulting in a clean slat

TLDR: The new task state representation is more verbose but significantly cleaner and fixes some bugs. It breaks compatibility with old states, so ensure there are no important tasks in your queue before updating. You'll also need to recreate groups.

### Fixed

- Fixed delay after sending process related commands from client. [#548](https://github.com/Nukesor/pueue/pull/548)

### Change

- **Breaking**: Refactor internal task state. Some task variables have been moved into the `TaskStatus` enum, which now enforces various invariants during compile time via the type system.
Expand All @@ -59,6 +55,11 @@ TLDR: The new task state representation is more verbose but significantly cleane
- Add `command` filter to `pueue status`. [#524](https://github.com/Nukesor/pueue/issues/524) [#560](https://github.com/Nukesor/pueue/pull/560)
- Allow `pueue status` to order tasks by `enqueue_at`. [#554](https://github.com/Nukesor/pueue/issues/554)

### Fixed

- Fixed delay after sending process related commands from client. [#548](https://github.com/Nukesor/pueue/pull/548)
- Callback templating arguments were html escaped by accident. [#564](https://github.com/Nukesor/pueue/pull/564)

## \[3.4.1\] - 2024-06-04

### Added
Expand Down
1 change: 1 addition & 0 deletions pueue/src/daemon/callbacks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ pub fn build_callback_command(
// Init Handlebars. We set to strict, as we want to show an error on missing variables.
let mut handlebars = Handlebars::new();
handlebars.set_strict_mode(true);
handlebars.register_escape_fn(handlebars::no_escape);

// Add templating variables.
let mut parameters = HashMap::new();
Expand Down

0 comments on commit 70cfb6c

Please sign in to comment.