Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why not checking the reply in you api for checkDevKey #10

Open
krysalead opened this issue Jan 28, 2019 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@krysalead
Copy link

Hi,

Thanks for this library, I was wondering why we have to check in the resolve method of the promise checkDevKey if the reply is true or false. Shouldn't be done on the API side and do a reject in case of false?

Thanks

K

@Nyaran
Copy link
Owner

Nyaran commented Feb 4, 2019

The intend for this module, is to communicate directly with TestLink API, that's the reason because any method is checking the response.
Anyway, I think could be a good idea to add some checks, so I will add it in a future release.

@Nyaran Nyaran added the enhancement New feature or request label Feb 4, 2019
@Nyaran Nyaran self-assigned this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants