chore(lint): rework linting stuff

.github/dependabot.yml

@@ -1,6 +1,6 @@
 version: 2
 updates:
-  - package-ecosystem: 'github-actions'
-    directory: '/'
+  - package-ecosystem: github-actions
+    directory: /
     schedule:
-      interval: 'daily'
+      interval: daily

.github/workflows/codeql-analysis.yml

@@ -9,7 +9,7 @@
 # the `language` matrix defined below to confirm you have the correct set of
 # supported CodeQL languages.
 #
-name: 'CodeQL'
+name: CodeQL
 
 on:
   push:
@@ -18,7 +18,7 @@ on:
     # The branches below must be a subset of the branches above
     branches: [master]
   schedule:
-    - cron: '25 20 * * 4'
+    - cron: 25 20 * * 4
 
 jobs:
   analyze:
@@ -28,7 +28,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        language: ['javascript']
+        language: [javascript]
         # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
         # Learn more:
         # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

.github/workflows/semgrep-analysis.yml

@@ -12,10 +12,10 @@ on:
   workflow_dispatch: {}
   # Scan mainline branches and report all findings:
   push:
-    branches: ["master", "main"]
+    branches: [master, main]
   # Schedule the CI job (this method uses cron syntax):
   schedule:
-    - cron: '24 3 * * 3'
+    - cron: 24 3 * * 3
 
 jobs:
   semgrep:
@@ -55,4 +55,4 @@ jobs:
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: ./securecodewarrior.sarif
-        if: always()
+        if: always()

.github/workflows/validate-codeowners.yml

@@ -1,5 +1,7 @@
 name: Validate Codeowners file
 
+permissions: read-all
+
 on:
   push:
     branches:
@@ -9,8 +11,6 @@ on:
   pull_request:
     branches:
       - '**'
-    tags-ignore:
-      - '**'
 
 jobs:
   validate-codeowners:
@@ -32,8 +32,8 @@ jobs:
           #        so we will not be using it for now
           # duppaterns: Reports if codeowners file contains duplicated lines
           # syntax: Reports if file contains an invalid syntax definition
-          checks: 'files,duppatterns,syntax'
-          experimental_checks: 'notowned'
+          checks: files,duppatterns,syntax
+          experimental_checks: notowned
 
           # GitHub access token is required only if the `owners` check is enabled
           #github_access_token: "${{ secrets.OWNERS_VALIDATOR_PAC }}"

charts/oada/Chart.yaml

@@ -9,7 +9,7 @@ maintainers:
     email: alex@layton.in
 type: application
 version: 3.4.0
-appVersion: '3.10.0'
+appVersion: 3.10.0
 annotations:
   artifacthub.io/recommendations: |
     - url: https://artifacthub.io/packages/helm/cert-manager/cert-manager

common.yml

@@ -16,7 +16,7 @@ services:
       CONFIG: ${OADA_CONFIG-/oada.config.mjs}
       # Default to development
       NODE_ENV: ${NODE_ENV-development}
-      NODE_OPTIONS: "$$INSPECT --enable-source-maps --unhandled-rejections=strict"
+      NODE_OPTIONS: $$INSPECT --enable-source-maps --unhandled-rejections=strict
       INSPECT: ${INSPECT---inspect=0.0.0.0:9229}
       DEBUG: ${DEBUG-*}
       PINO_LEVEL: ${PINO_LEVEL-debug}

docker-compose.yml

@@ -44,7 +44,7 @@ services:
       args:
         OADA_SERVICE: http-handler
     healthcheck:
-      test: [ 'CMD', 'yarn', 'healthcheck' ]
+      test: [ CMD, yarn, healthcheck ]
     depends_on:
       - startup
     networks:
@@ -204,7 +204,7 @@ services:
       # - ARANGO_RANDOM_ROOT_PASSWORD=1
       ARANGO_NO_AUTH: 1
       ARANGO_STORAGE_ENGINE: rocksdb
-    command: [ 'arangod', '--server.statistics=false' ]
+    command: [ arangod, --server.statistics=false ]
 
   # Redpanda is API compatible with kafka.
   redpanda:
@@ -292,7 +292,7 @@ services:
       - prometheus_config:/etc/prometheus
     user: root
     entrypoint:
-      - '/bin/sh'
+      - /bin/sh
       - -c
     command:
       - |
@@ -312,7 +312,7 @@ services:
     networks:
       grafana_net:
     ports:
-      - '3000:3000'
+      - 3000:3000
     volumes:
       - grafana_data:/var/lib/grafana
       - grafana_prov:/etc/grafana/provisioning
@@ -331,7 +331,7 @@ services:
     volumes:
       - grafana_prov:/etc/grafana/provisioning
     entrypoint:
-      - '/bin/sh'
+      - /bin/sh
       - -c
     command:
       - |
@@ -355,7 +355,7 @@ services:
     volumes:
       - grafana_prov:/etc/grafana/provisioning
     entrypoint:
-      - '/bin/sh'
+      - /bin/sh
       - -c
     command:
       - |
@@ -382,7 +382,7 @@ services:
       - grafana_data:/var/lib/grafana
       - grafana_prov:/etc/grafana/provisioning
     entrypoint:
-      - '/bin/sh'
+      - /bin/sh
       - -c
     command:
       - |
@@ -416,14 +416,14 @@ networks:
 x-mutagen:
   forward:
     agrango:
-      source: 'tcp:localhost:8529'
-      destination: 'network://arango_net:tcp:arangodb:8529'
+      source: tcp:localhost:8529
+      destination: network://arango_net:tcp:arangodb:8529
     kafka:
-      source: 'tcp:localhost:9092'
-      destination: 'network://kafka_net:tcp:kafka:9092'
+      source: tcp:localhost:9092
+      destination: network://kafka_net:tcp:kafka:9092
     prometheus:
-      source: 'tcp:localhost:9090'
-      destination: 'network://grafana_net:tcp:prometheus:9090'
+      source: tcp:localhost:9090
+      destination: network://grafana_net:tcp:prometheus:9090
     grafana:
-      source: 'tcp:localhost:3000'
-      destination: 'network://grafana_net:tcp:grafana:3000'
+      source: tcp:localhost:3000
+      destination: network://grafana_net:tcp:grafana:3000

eslint.config.mjs

@@ -0,0 +1,21 @@
+/**
+ * @license
+ * Copyright 2024 Open Ag Data Alliance
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// @ts-check
+
+export * from './oada/eslint.config.mjs';
+

oada-server.code-workspace

@@ -117,19 +117,20 @@
     "prettier.prettierPath": "oada/.yarn/sdks/prettier/index.js",
     "typescript.tsdk": "oada/.yarn/sdks/typescript/lib",
     "typescript.enablePromptUseWorkspaceTsdk": true,
-    "eslint.nodePath": "../../.yarn/sdks",
-    "eslint.workingDirectories": [{ "directory": "./oada/", "!cwd": true }],
+    "eslint.nodePath": "../../../oada/.yarn/sdks",
     "files.exclude": {
       ".actrc": true,
-      ".history": true,
       ".dccache": true,
+      ".history": true,
       "**/.DS_Store": true,
       "**/.grunt": true,
+      "**/.history": true,
       "**/.lock-wscript": true,
       "**/.node_repl_history": true,
       "**/.npm": true,
       "**/.nyc_output": true,
       "**/.pnp.*": true,
+      "**/.test": true,
       "**/.vim": true,
       "**/.yarn": true,
       "**/*.log": true,
@@ -138,7 +139,6 @@
       "**/*.tsbuildinfo": true,
       "**/coverage": true,
       "**/dist": true,
-      "**/.test": true,
       "**/lib-cov": true,
       "**/logs": true,
       "**/node_modules": true,
@@ -211,11 +211,19 @@
       "Yaguang",
       "Zhang"
     ],
-    "eslint.useESLintClass": true,
     "licenser.author": "Open Ag Data Alliance",
     "licenser.license": "AL2",
     "commitlint.config.file": "oada/commitlint.config.cjs",
     "html.format.templating": true,
-    "html.validate.styles": false
+    "html.validate.styles": false,
+    "eslint.format.enable": true,
+    "eslint.lintTask.enable": true,
+    "eslint.useFlatConfig": true,
+    "eslint.debug": true,
+    "eslint.useESLintClass": true,
+    "eslint.validate": [
+      "typescript",
+      "javascript"
+    ]
   }
-}
+}

oada/.vscode/settings.json

@@ -10,7 +10,5 @@
     "**/.pnp.*": true
   },
   "prettier.prettierPath": ".yarn/sdks/prettier/index.cjs",
-  "typescript.tsdk": ".yarn/sdks/typescript/lib",
-  "typescript.enablePromptUseWorkspaceTsdk": true,
   "eslint.nodePath": ".yarn/sdks"
 }