Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FWP] account_multicurrency_revaluation #242

Merged

Conversation

MiquelRForgeFlow
Copy link
Contributor

Forward port of #200.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fwp-account_multicurrency_revaluation branch 8 times, most recently from 8536222 to 80a7531 Compare March 15, 2023 17:32
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fwp-account_multicurrency_revaluation branch from 80a7531 to 78a2ad1 Compare March 16, 2023 10:21
Copy link
Contributor

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fwp-account_multicurrency_revaluation branch from 78a2ad1 to 77c244f Compare March 16, 2023 15:10
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 16, 2023
@github-actions github-actions bot closed this Aug 20, 2023
@etobella etobella reopened this Aug 21, 2023
@etobella etobella removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 21, 2023
Adapt helps to suggestions and adapt method declarartion to improve the experience of users/developers.
Removed as it may lead to problems just because the entry may have the currency from the company, and the lines having a different currency. Then we will not be able to post the entry.
Wizard to be able to create the reverse moves given an start date and end date. All revaluated entries during the period will be included and upon the validation, the reverse moves will be created. Also you can determine a posting date which will be the date assigned to all reverse moves created.
Remove the setting that allowed the user to possibly flag the revaluated entries created during the main process. Always flag them instead to be used later in the reverse wizard.
Make both fields readonly as they will be only used in the logic and to filter, the user will not modify them. Also, limit entries appearing in reverse wizard.
Adds the origin line from where the revaluated line is created. Also, improves the query to get the open items.
Before, the lines were overwriten, so if there were multiple lines for the same account, partner and currency, the last open item was the only one used. Now the amounts are acumulated into one line.
Two-sided relation between lines created and original ones
…nciled items

If the origin line that will be revaluated has partially reconciled items, adjust the values to the real ones.
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-fwp-account_multicurrency_revaluation branch from 77c244f to 1146c8e Compare August 21, 2023 10:40
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LG!

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-242-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b9f2be2 into OCA:14.0 Aug 22, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8b7a71f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants