-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][FWP] account_multicurrency_revaluation #259
[15.0][FWP] account_multicurrency_revaluation #259
Conversation
85e4277
to
f897df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LG!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏽
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
/ocabot merge minor |
On my way to merge this fine PR! |
…& Include Only Posted Entries
…n the revaluation
Adapt helps to suggestions and adapt method declarartion to improve the experience of users/developers.
Removed as it may lead to problems just because the entry may have the currency from the company, and the lines having a different currency. Then we will not be able to post the entry.
Wizard to be able to create the reverse moves given an start date and end date. All revaluated entries during the period will be included and upon the validation, the reverse moves will be created. Also you can determine a posting date which will be the date assigned to all reverse moves created.
Remove the setting that allowed the user to possibly flag the revaluated entries created during the main process. Always flag them instead to be used later in the reverse wizard.
Make both fields readonly as they will be only used in the logic and to filter, the user will not modify them. Also, limit entries appearing in reverse wizard.
Adds the origin line from where the revaluated line is created. Also, improves the query to get the open items.
Before, the lines were overwriten, so if there were multiple lines for the same account, partner and currency, the last open item was the only one used. Now the amounts are acumulated into one line.
Two-sided relation between lines created and original ones
…nciled items If the origin line that will be revaluated has partially reconciled items, adjust the values to the real ones.
f897df4
to
ab32712
Compare
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at f6b5ac3. Thanks a lot for contributing to OCA. ❤️ |
Forward port of #242.