[MIG] - migrate account_cutoff_accrual_picking into account_cutoff_picking #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy
….get('type', '-')
…a single warning left ! Add translation template files.
Allow use of the cutoff modules by Accountant (and not only Financial manager) Set default cutoff date to last day of previous fiscal year Move button to generate lines to account_cutoff_base module Block deletion of 'done' cutoff Use accounting configuration page instead of company form view Code clean-up and minor fixes
sbejaoui
force-pushed
the
16.0-account_cutoff_picking-sbj
branch
2 times, most recently
from
245f5cd
to
b580c26
Compare
sbejaoui
force-pushed
the
16.0-account_cutoff_picking-sbj
branch
from
b580c26
to
53d39bb
Compare
|
@alexis-via @sbejaoui @jbaudoux Could we find an agreement on changes for this one as this make me frighten about mixing implementations? Thanks |
jbaudoux
reviewed
Sep 20, 2023
|
|
||
| { | ||
| "name": "Account Cut-off Picking", | ||
| "version": "16.0.1.2.0", | ||
| "category": "Accounting", | ||
| "version": "16.0.1.0.0", |
There was a problem hiding this comment.
Suggested change
| "version": "16.0.1.0.0", | |
| "version": "16.0.2.0.0", |
jbaudoux
suggested changes
Oct 6, 2023
| tax_read = self.env["account.tax"].browse(tax_line["id"]) | ||
| tax_cutoff_account_id = tax_read[tax_account_field_name] | ||
| if not tax_cutoff_account_id: | ||
| if not company.cutoff_taxes: |
There was a problem hiding this comment.
Suggested change
| if not company.cutoff_taxes: | |
| if not company.accrual_taxes: |
There was a problem hiding this comment.
missing test coverage on taxes
|
Replaced by #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR #73
cc/ @alexis-via , @jbaudoux