18.0 mig account invoice start end dates #307

fredericgrall · 2024-10-30T13:47:33Z

No description provided.

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

…art_end_dates: fixing tests fixing product not found convert mline dates to string fixing flake8 account_invoice_start_end_dates: fixing tests fixing product not found convert mline dates to string fixing flake8 putting removed licences back fix tests fix flake8 fix pylint issues [12.0-mig-account] fix unit tests fixup! [12.0-mig-account] fix unit tests fixup! fixup! [12.0-mig-account] fix unit tests

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-12.0/account-closing-12.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_invoice_start_end_dates/

Default value for cutoff date is end date of previous fiscal year

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-13.0/account-closing-13.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-13-0/account-closing-13-0-account_invoice_start_end_dates/

Currently translated at 88.2% (15 of 17 strings) Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/fr_FR/

Currently translated at 100.0% (14 of 14 strings) Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/pt/

Currently translated at 100.0% (14 of 14 strings) Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/it/

Currently translated at 15.3% (2 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fa/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr_FR/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/it/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/

Remove deprecated POT files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/es/

Currently translated at 92.3% (12 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/hr/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/

Co-authored-by: Alexis de Lattre <alexis@via.ecp.fr>

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-17.0/account-closing-17.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-17-0/account-closing-17-0-account_invoice_start_end_dates/it/

xaviedoanhduy

For being easily searchable and avoiding to duplicate efforts, please name the pull request following this pattern:
[18.0][MIG] <module>: Migration to 18.0.

xaviedoanhduy · 2024-11-08T04:32:26Z

account_invoice_start_end_dates/models/account_move.py

+                    and (not line.start_date or not line.end_date)
+                ):
+                    raise UserError(
+                        _(


could you apply this change to _ and % similar to this PR?
odoo/odoo#52155

xaviedoanhduy · 2024-11-08T04:45:53Z

account_invoice_start_end_dates/views/account_move.xml

+                position="before"
+            >
+                <field name="must_have_dates" invisible="1" />
+                <field name="start_date" required="must_have_dates == True" />


Suggested change

<field name="start_date" required="must_have_dates == True" />

<field name="start_date" required="must_have_dates" />

why not take this opportunity to simplify the boolean expression above?

xaviedoanhduy · 2024-11-08T04:49:47Z

account_invoice_start_end_dates/readme/CONTRIBUTORS.md

+- Jeroen Evens \<<jeroen.evens@dynapps.be>\>
+- [Trobz](https://trobz.com):  
+  - Thao Le <thaolt@trobz.com>
+- Frederic Grall \<<fgr@apik.cloud>>


can you add a new line

xaviedoanhduy · 2024-11-08T04:51:55Z

could you squash 2 commit MIG to 18.0 in a single one and btw squash administrative commits?

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

xaviedoanhduy · 2024-11-08T05:12:08Z

account_invoice_start_end_dates/views/account_move.xml

+                expr="//field[@name='invoice_line_ids']/list/field[@name='quantity']"
+                position="before"
+            >
+                <field name="must_have_dates" invisible="1" />


Suggested change

<field name="must_have_dates" invisible="1" />

<field name="must_have_dates" column_invisible="1" />

alexis-via and others added 30 commits October 30, 2024 14:25

Port account_cutoff_base and account_cutoff_prepaid to Odoo v9

1739353

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Migration of account_cutoff modules to 10.0

05fed80

account_invoice_start_end_dates: Migration to 11.0

c98d512

Savepoint tests invoice_start

65aca68

OCA Transbot updated translations from Transifex

8b99fc9

README.rst

8762512

icon.png

6b3c449

README.rst

aa44ba5

[MIG] account_invoice_start_end_dates to v13

20dda57

Black

f0db7a8

Use super() instead of super(classname, self)

f394a7b

[UPD] README.rst

aece33d

Black and other pre-commit stuff

4a40c0a

FIX visibility of forecast button

cac3733

Default value for cutoff date is end date of previous fiscal year

[UPD] README.rst

0df4db0

[UPD] README.rst

60e21fb

[FIX] lint issues

c1a149b

[MIG] account_invoice_start_end_dates from 13 to 14

d20c4e2

[UPD] README.rst

e63c59a

account_invoice_start_end_dates 14.0.1.0.1

c19b7bd

Added translation using Weblate (French (France))

a5d0834

[MIG] account_invoice_start_end_dates to v15

7fae55b

[UPD] README.rst

bc9bd73

mostafabarmshory and others added 26 commits October 30, 2024 14:25

cutoff modules: improve strings

e97d545

Remove deprecated POT files

[UPD] Update account_invoice_start_end_dates.pot

371894f

account_invoice_start_end_dates 16.0.1.2.0

82c0294

Added translation using Weblate (Spanish)

4ade66a

[UPD] README.rst

5cce0a1

[TRN] remove fr_FR.po

b863d33

Co-authored-by: Alexis de Lattre <alexis@via.ecp.fr>

[IMP] account_invoice_start_end_dates: pre-commit auto fixes

00763eb

[MIG] account_invoice_start_end_dates: Migration to 17.0

3101d62

[UPD] Update account_invoice_start_end_dates.pot

9258e52

[BOT] post-merge updates

c93d68b

[FIX] account_cutoff_start_end_dates: fix view migration to v17

e40070e

[BOT] post-merge updates

7a9301d

[MIG] account_invoice_start_end_dates: Migration to 18.0

bdb4da0

[MIG] account_invoice_start_end_dates: Migration to 18.0

67c656f

xaviedoanhduy suggested changes Nov 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18.0 mig account invoice start end dates #307

18.0 mig account invoice start end dates #307

fredericgrall commented Oct 30, 2024

xaviedoanhduy left a comment •

edited

Loading

xaviedoanhduy Nov 8, 2024

xaviedoanhduy Nov 8, 2024

xaviedoanhduy Nov 8, 2024

xaviedoanhduy commented Nov 8, 2024 •

edited

Loading

xaviedoanhduy Nov 8, 2024

	<field name="start_date" required="must_have_dates == True" />
	<field name="start_date" required="must_have_dates" />

	<field name="must_have_dates" invisible="1" />
	<field name="must_have_dates" column_invisible="1" />

18.0 mig account invoice start end dates #307

Are you sure you want to change the base?

18.0 mig account invoice start end dates #307

Conversation

fredericgrall commented Oct 30, 2024

xaviedoanhduy left a comment • edited Loading

Choose a reason for hiding this comment

xaviedoanhduy Nov 8, 2024

Choose a reason for hiding this comment

xaviedoanhduy Nov 8, 2024

Choose a reason for hiding this comment

xaviedoanhduy Nov 8, 2024

Choose a reason for hiding this comment

xaviedoanhduy commented Nov 8, 2024 • edited Loading

xaviedoanhduy Nov 8, 2024

Choose a reason for hiding this comment

xaviedoanhduy left a comment •

edited

Loading

xaviedoanhduy commented Nov 8, 2024 •

edited

Loading