[12.0][FIX] account_financial_report: Support Postgres v14+ #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres 14+ expects the argument anycompatiblearray instead of anyarray to array_cat. We detect the Postgres version and proceed with the correct type. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
12.0-postgres-14
branch
from
c3116d3
to
0b30aa7
Compare
|
For clarity, I have tested this against a Postgres 12 and a Postgres 14 database. For easy testing, use: and then set Alternatively, use Docker instead of podman. They have the same command-line arguments, I think. |
|
This PR has the |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
This was referenced Aug 24, 2023
|
Congratulations, your PR was merged at 370d135. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres 14+ expects the argument anycompatiblearray instead of anyarray to array_cat. We detect the Postgres version and proceed with the correct type.
The refactoring in #660 would also fix this problem, and certainly fixes it for future Odoo versions, but that PR is marked do-not-merge.
Internal task: https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=10965&active_id=10965&menu_id=