[15.0][FIX] account_sale_stock_report_non_billed: Date can't be comparated with bool #1058
Conversation
CarlosRoca13
force-pushed
the
15.0-FIX-account_sale_stock_report_non_billed
branch
from
a4c5f03
to
67406b2
Compare
| @@ -127,6 +127,8 @@ def _compute_not_invoiced_values(self): | |||
| moves_in_date = invoices_not_cancel.mapped("move_line_ids").filtered( | |||
| lambda m: m.date_done >= date_start and m.date_done <= date_end | |||
| ) | |||
| if not self.env.context.get("date_check_iterval_restrict", False): | |||
| date_start = False | |||
There was a problem hiding this comment.
I don't get why do you need this. Pass the minimum variables in context, and the absence of one of them means that no check should be done.
There was a problem hiding this comment.
Because we need the date_start and the date_end to filter the move_line_ids in any situation, but when the user doesn't want to use this dates as a range for invoices too the date_start has to be reset to False.
There was a problem hiding this comment.
Yes, and that's why I say you only need to pass one variable: the start date. If not passed, then you use .get(..., False), and being False means that no check has to be done.
There was a problem hiding this comment.
But I need the date_start to take the moves_in_date
There was a problem hiding this comment.
OK, I'm getting it. They should be independent variables for avoiding that clunky logic. Pass these 3 possible variables to context:
non_billed_date: Olddate_check_invoiced_movesnon_billed_date_start: Olddate_check_invoiced_moves_startnon_billed_invoice_date_start: This one is set toself.stock_move_non_billed_thresholdifself.interval_restrict_invoices.
and you get each of them on the computing code, with no inter-dependencies between them.
CarlosRoca13
force-pushed
the
15.0-FIX-account_sale_stock_report_non_billed
branch
from
67406b2
to
0d232de
Compare
CarlosRoca13
force-pushed
the
15.0-FIX-account_sale_stock_report_non_billed
branch
from
0d232de
to
e229ebc
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 9bc9aad. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT44745
fw-port of: #953
ping @pedrobaeza @stefan-tecnativa