[16.0][ADD] account_invoice_qr_code_sepa_payconiq #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirGuesmi
force-pushed
the
16.0-mig-account_invoice_qr_code_sepa_payconiq
branch
2 times, most recently
from
7c21932
to
05be9ed
Compare
samirGuesmi
force-pushed
the
16.0-mig-account_invoice_qr_code_sepa_payconiq
branch
from
05be9ed
to
cc0295e
Compare
|
Hello @rousseldenis If you could provide a feedback for this PR. |
sbejaoui
approved these changes
Nov 7, 2024
Comment on lines
+13
to
+14
| PAYCONIQ_URL = "https://payconiq.com/t/1/" | ||
| PAYCONIQ_QR_URL = "https://portal.payconiq.com/qrcode" |
There was a problem hiding this comment.
Just a small suggestion: It would be better to fetch this from ir.config_parameter, allowing admin to easily update the URL if Payconiq changes it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward port: #1248