[17.0][FW] account_invoice_section_sale_order: multiple ports from 16.0 #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
changed the title
sebalix
force-pushed
the
oca-port-account_invoice_section_sale_order-16.0-to-17.0-56f4f0
branch
from
1bef9cf
to
18ba581
Compare
henrybackman
approved these changes
Sep 25, 2024
grindtildeath
approved these changes
Sep 25, 2024
|
@grindtildeath that would be better yes, but the downside of doing that is that we are still generating conflicts we need to resolve in a separate commit on each version, while updating the current patch one version after the other makes the port simpler. In an ideal world, when someone propose a patch on a given version, he could take the opportunity to port it straight to the next versions so that will be same commit+author and he could amend it without issue (here with what I have done, I'm not the author of the adaptations). EDIT: I didn't understood well your comment, it's OK now |
sebalix
force-pushed
the
oca-port-account_invoice_section_sale_order-16.0-to-17.0-56f4f0
branch
from
18ba581
to
04bcbb1
Compare
Refactor preparation of sections Refactor to allow different section grouping Add field to allow different possibilities of grouping invoice lines from sale order
…on tests
In OCA repo, now we have this error:
Traceback (most recent call last):
File "/__w/account-invoicing/account-invoicing/account_invoice_section_sale_order/tests/test_invoice_group_by_sale_order.py", line 109, in test_create_invoice
self.assertEqual(line.name, result[line.sequence][0])
KeyError: 1
sebalix
force-pushed
the
oca-port-account_invoice_section_sale_order-16.0-to-17.0-56f4f0
branch
from
04bcbb1
to
8cd1abd
Compare
|
@grindtildeath fixup fixed & squashed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same port than:
Port of the following PRs from 14.0 to 17.0:
account_invoice_section_sale_orderregarding tests)