-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_move_tier_validation: Migration to 18.0 #1830
Open
kevinkhao
wants to merge
57
commits into
OCA:18.0
Choose a base branch
from
kevinkhao:18.0-mig-account_move_tier_validation
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] account_move_tier_validation: Migration to 18.0 #1830
kevinkhao
wants to merge
57
commits into
OCA:18.0
from
kevinkhao:18.0-mig-account_move_tier_validation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (13 of 13 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_move_tier_validation/zh_CN/
Currently translated at 100.0% (22 of 22 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
* 'Validation In Progress' so as to allow an easy location of the invoices for which a validation has been triggered, but it is not yet completed. * 'Validation Not Started' to locate bills that either require no validation, or the request for validation has not yet been initiated.
…not working correctly
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/
Currently translated at 100.0% (27 of 27 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_move_tier_validation/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/
Currently translated at 100.0% (26 of 26 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
Currently translated at 100.0% (27 of 27 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
Currently translated at 100.0% (27 of 27 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/sv/
…moves with tier validation Added tests for changes Updated error to be checked in tests Updated error to be checked in tests
Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/it/
kevinkhao
force-pushed
the
18.0-mig-account_move_tier_validation
branch
4 times, most recently
from
November 11, 2024 06:55
d3a8636
to
abfa1b4
Compare
@xaviedoanhduy done |
xaviedoanhduy
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bosd
suggested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small improvements.
kevinkhao
force-pushed
the
18.0-mig-account_move_tier_validation
branch
2 times, most recently
from
November 12, 2024 06:27
6009106
to
40dc33f
Compare
kevinkhao
force-pushed
the
18.0-mig-account_move_tier_validation
branch
from
November 12, 2024 06:35
40dc33f
to
62b36c7
Compare
@bosd thx for feedback, done |
Wdyt about promoting module maturity? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on OCA/server-ux#966