[15.0][IMP] sale_commission: print partial and document total in report

[toita86]

FWP of #570 the implementation is a little bit different due to other modules dependance on the position of certain elements in the report.

[OCA-git-bot]

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

[toita86]

Hi @aleuffre, while FW you feature to adapt it to v15.0 I needed to change the position of the div that contains the total.

but now looks like this:

Do you have any suggestion that could make it more similar to you implementation?

[aleuffre]

Hi @aleuffre, while FW you feature to adapt it to v15.0 I needed to change the position of the div that contains the total.

but now looks like this:
Do you have any suggestion that could make it more similar to you implementation?

I took heavy inspiration from a similar section in the Sales Order report. As you can see, what I did was put the total outside the table and tfoot element, because the tfoot like the thead is printed again on every page, which is something we wanted to avoid.

So yes, I would try to put the total in a div, outside the table itself

[toita86]

So yes, I would try to put the total in a div, outside the table itself

At first i didn't wanted to move it outside because the module account_commission used the tfoot on to add some spaces

commission/account_commission/views/report_settlement_templates.xml

Line 41 in 40491a3

<xpath expr="//table/tfoot/tr/td" position="before">

by removing the xpath element added in account_commission and moving the div outside everything looks fine in IMO.
Now this is the output

[aleuffre]

issue: Since this is the total for all pages being printed, I don't think it should be printed inside the foreach (line 95), as you only want this printed once, not once for every commission.

[toita86]

Thank you for your observation. While it's true that the total is printed inside the for each loop, it actually maintains the same behavior as in the 14.0.

[aleuffre]

Code review, LGTM

[francesco-ooops]

LGTM

@pedrobaeza merge?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-572-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 2ef3624. Thanks a lot for contributing to OCA. ❤️