[14.0][FIX] sale_commission_partial_settlement: handle settlement deletion #575
+165
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renda-dev, @PicchiSeba, |
aleuffre
force-pushed
the
14.0-commission-partial-delete
branch
2 times, most recently
from
e01b4f9
to
672c126
Compare
|
Also added migration scripts |
aleuffre
force-pushed
the
14.0-commission-partial-delete
branch
5 times, most recently
from
ddef925
to
ab5e010
Compare
francesco-ooops
approved these changes
Nov 13, 2024
This commit fixes an issue where, if a settlement was deleted, any partial commission would not be recreated because it was still considered paid. Includes a small refactor of the files and deletion of some unused fields.
aleuffre
force-pushed
the
14.0-commission-partial-delete
branch
from
ab5e010
to
9b2ece1
Compare
|
Added a new field "is_fully_settled" |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 9ee050b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where, if a settlement was deleted or canceled, any partial commission would not be recreated because it was still considered paid.
Includes a small refactor of the files and deletion of some unused fields.