[17.0][MIG] account_financial_risk: Migration to 17.0 #347

Mat-moran · 2023-12-14T11:37:55Z

Change version in manifest
Adapt views to version 17.0

* [9.0][IMP] partner_financial_risk: Improve performance * [9.0][IMP] partner_financial_risk: Improve tests and partner hierarchy * [9.0][IMP] partner_stock_risk: Test

…ft_invoices

- Refunds adds partner risk instead of reduce. - If date_maturity changes to previous today date "never" compute partner risk.

* [9.0][IMP] partner_financial_risk: Improve multicompany cron * [9.0][IMP] partner_financial_risk: Exec with sudo (cherry picked from commit 6590bbf)

…idation

…ation wizard

Currently translated at 71.2% (52 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/fr/

Currently translated at 79.5% (58 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/it/

…o False.

Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es/

Currently translated at 13.7% (10 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es_CL/

Currently translated at 76.7% (56 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt_BR/

Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt/

…ption. Improve views and translations.

…nfig settings

…le_financial_risk: - Optimize code and change stored computed fields to not store to improve multi-company support - Improve multi-currency support - Convert risk amount fields to clickable link that shows traceability of amount origin - New pivot views to risk amount traceability - Simplify class style applied on risk fields - Migration script to remove old stored computed fields - Improve tests to cover new functionallity - Update translation files account_financial_risk: - Don't block refund invoice validation when partner has risk exception - Allow search partners by risk exception field - Remove obsolete cron sale_financial_risk - Create related store commercial_partner_id field in sale order line to simplify computation - Rename amt_to_invoice field to risk_amount in sale order line - Hook and migration scripts to reduce new fields computing time TT23765

This commit adds an specific group for overpassing partner credit limit exceptions In some situations, not only account managers shoud be allowed to overpass exception, depending on the company policies. Merging this code will not affect current instances, as long as account managers will be added to the new group.

…that depend on a non-stored field

Currently translated at 53.8% (49 of 91 strings) Translation: credit-control-16.0/credit-control-16.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_financial_risk/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_financial_risk/

…lexibility TT26717 TT31209

… buttons [IMP] account_financial_risk: Improve comments to make it more understandable TT32194

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_financial_risk/

Currently translated at 100.0% (94 of 94 strings) Translation: credit-control-16.0/credit-control-16.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_financial_risk/es/

- Include context keys for avoiding mail operations overhead.

…ecks to be not need to compute risk exception

[IMP] account_financial_risk: pre-commit auto fixes [MIG] account_financial_risk: Migration to 17.0 Refactor code for financial risk handling Update tax_group_taxes variable and add help text to invoice_unpaid_margin and allow_overrisk_invoice_validation settings [FIX] pre-commit [MIG] account_financial_risk: Migration to 17.0 [MIG] account_financial_risk: Migration to 17.0 [MIG] account_financial_risk: Migration to 17.0

Mat-moran · 2023-12-14T16:25:48Z

Hi, @pedrobaeza can you help on this? we have a problem with the field amount_residual_currency when the method_get_amount_in_risk_currency() is executed.

The field amount_residual_currency when is defined it explicetily as

amount_residual_currency = fields.Monetary(
    string='Residual Amount in Currency',
    compute='_compute_amount_residual', store=True,
    group_operator=None, # This is making the function fail
    help="The residual amount on a journal item expressed in its currency (possibly not the "
         "company currency).",
)

what do you sugest?

pedrobaeza · 2023-12-14T16:57:26Z

Sorry, I can't say, as I haven't dug on it.

carlosdauden

Ignore not related files as macOS.pkg

Take a look at:
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#7git

carlosdauden · 2023-12-15T07:53:57Z

account_financial_risk/models/res_partner.py

@@ -354,7 +354,6 @@ def _compute_risk_account_amount(self):
                group["domain"] + [("partner_id", "in", customers.ids)],
                group["fields"],
                group["group_by"],
-                orderby="id",


Use _read_group to remove this

I am not sure if I am understanding.

the return of _read_group is not the same as read_group

Look this:
#377 (review)

carlosdauden · 2023-12-15T07:54:17Z

account_financial_risk/data/account_financial_risk_data.xml

+<?xml version="1.0" ?>
+<odoo noupdate="1">
+        <!-- Account Tax Group -->
+        <record id="tax_group_taxes" model="account.tax.group">


Why this module adds new tax group?

Thanks for the review,

This was in odoo account module but has been removed in v17. As it is required by the test, so we added to this module.

# before v17 this data was on -> addons/account/data/account_data.xml  <record id="tax_group_taxes" model="account.tax.group"> <field name="name">Taxes</field> <field name="sequence">0</field> </record>

You should fix the test, not to add useless data.

gurneyalex · 2024-04-05T09:59:22Z

/ocabot migration account_financial_risk

ioans73 · 2024-04-11T15:17:42Z

@Mat-moran what is the status of this?

pedrobaeza · 2024-05-02T14:08:36Z

account_financial_risk/__manifest__.py

+{
+    "name": "Account Financial Risk",
+    "summary": "Manage customer risk",
+    "version": "17.0.1.0",


Suggested change

"version": "17.0.1.0",

"version": "17.0.1.0.0",

sbiosca-s73 · 2024-05-02T14:04:46Z

account_financial_risk/__manifest__.py

+{
+    "name": "Account Financial Risk",
+    "summary": "Manage customer risk",
+    "version": "17.0.1.0",


Please, put the version in the correctly form
17.0.1.0.0

pedrobaeza · 2024-05-23T06:38:11Z

Superseded by #379

carlosdauden and others added 30 commits December 14, 2023 11:37

[ADD] partner_financial_risk (OCA#292)

2532928

[9.0][FIX] partner_financial_risk: Refund were not contemplated

cf47539

[9.0][IMP] partner_financial_risk: Improve performance (OCA#385)

e6fa5c5

* [9.0][IMP] partner_financial_risk: Improve performance * [9.0][IMP] partner_financial_risk: Improve tests and partner hierarchy * [9.0][IMP] partner_stock_risk: Test

[9.0][FIX] partner_financial_risk: Error when risk_total includes dra…

de2d78e

…ft_invoices

[9.0][IMP] partner_financial_risk: Add track visibility to credit limit

0ce608a

[MIG] Partner Financial Risk : Migration to 10.0

20c05f1

[IMP] Minor changes

3eadb6d

[FIX] partner_financial_risk: Invoice refunds add risk

37d1d6e

- Refunds adds partner risk instead of reduce. - If date_maturity changes to previous today date "never" compute partner risk.

[IMP] partner_financial_risk: New fields in view. Improve code.

5e10cfa

[10.0][IMP] partner_financial_risk: Improve multicompany cron (#530)

c67d943

* [9.0][IMP] partner_financial_risk: Improve multicompany cron * [9.0][IMP] partner_financial_risk: Exec with sudo (cherry picked from commit 6590bbf)

[MIG] partner_financial_risk: Migration to 11.0

807e313

[REN] partner_financial_risk > account_financial_risk

3b905e4

[IMP] account_financial_risk: Improve table layout

07c9f1d

[IMP] account_financial_risk: Only block normal customer invoices val…

4f2c97b

…idation

[MIG] account_financial_risk: Migration to 12.0

c587ad1

[IMP] account_financial_risk: Manage risk in multiple invoice confirm…

e7e3956

…ation wizard

[FIX]account_financial_risk: risk_exception field explicitly setted t…

ca55180

…o False.

[IMP] account_financial_risk: Add allow overrisk invoice validation o…

11de0d3

…ption. Improve views and translations.

[IMP] account_financial_risk: Avoid compute all partners when save co…

cc77742

…nfig settings

[IMP] account_financial_risk: black, isort, prettier

7517bcd

[MIG] account_financial_risk: Migration to 13.0

5940960

[IMP] Add selection: choose which currency should be used in risk

2b7d55b

carlosdauden and others added 14 commits December 14, 2023 11:37

[IMP] account_financial_risk: Remove store parameter from two fields …

fb004cb

…that depend on a non-stored field

oca-github-bot post-merge updates

84f0944

[IMP] account_financial_risk: Change risk tab group to new for more f…

a9b86ea

…lexibility TT26717 TT31209

[FIX] account_financial_risk: Active model not in context from header…

4d9b53d

… buttons [IMP] account_financial_risk: Improve comments to make it more understandable TT32194

[UPD] Update account_financial_risk.pot

ca35d4d

[BOT] post-merge updates

7159107

[IMP] account_financial_risk: test performance improvement

b7b6804

- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates

b89f8a6

[FIX] account_financial_risk: Recover original behavior of include ch…

d90818d

…ecks to be not need to compute risk exception

[BOT] post-merge updates

7022590

cramosh force-pushed the 17.0-mig-account_financial_risk branch from dc58a91 to 966f63e Compare December 14, 2023 15:52

cramosh force-pushed the 17.0-mig-account_financial_risk branch from 966f63e to e6354c7 Compare December 14, 2023 15:55

carlosdauden suggested changes Dec 15, 2023

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Apr 5, 2024

OCA-git-bot mentioned this pull request Apr 5, 2024

Migration to version 17.0 #338

Open

10 tasks

sbiosca-s73 mentioned this pull request May 2, 2024

[17.0][MIG] sale_financial_risk #377

Merged

pedrobaeza reviewed May 2, 2024

View reviewed changes

sbiosca-s73 reviewed May 2, 2024

View reviewed changes

sbiosca-s73 mentioned this pull request May 22, 2024

[17.0][MIG] account_financial_risk #379

Merged

pedrobaeza closed this May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_financial_risk: Migration to 17.0 #347

[17.0][MIG] account_financial_risk: Migration to 17.0 #347

Mat-moran commented Dec 14, 2023

Mat-moran commented Dec 14, 2023

pedrobaeza commented Dec 14, 2023

carlosdauden left a comment

carlosdauden Dec 15, 2023

Mat-moran Dec 15, 2023

carlosdauden May 2, 2024

carlosdauden Dec 15, 2023

Mat-moran Dec 15, 2023 •

edited

Loading

pedrobaeza May 2, 2024

gurneyalex commented Apr 5, 2024

ioans73 commented Apr 11, 2024

pedrobaeza May 2, 2024

sbiosca-s73 May 2, 2024

pedrobaeza commented May 23, 2024

[17.0][MIG] account_financial_risk: Migration to 17.0 #347

[17.0][MIG] account_financial_risk: Migration to 17.0 #347

Conversation

Mat-moran commented Dec 14, 2023

Mat-moran commented Dec 14, 2023

pedrobaeza commented Dec 14, 2023

carlosdauden left a comment

Choose a reason for hiding this comment

carlosdauden Dec 15, 2023

Choose a reason for hiding this comment

Mat-moran Dec 15, 2023

Choose a reason for hiding this comment

carlosdauden May 2, 2024

Choose a reason for hiding this comment

carlosdauden Dec 15, 2023

Choose a reason for hiding this comment

Mat-moran Dec 15, 2023 • edited Loading

Choose a reason for hiding this comment

pedrobaeza May 2, 2024

Choose a reason for hiding this comment

gurneyalex commented Apr 5, 2024

ioans73 commented Apr 11, 2024

pedrobaeza May 2, 2024

Choose a reason for hiding this comment

sbiosca-s73 May 2, 2024

Choose a reason for hiding this comment

pedrobaeza commented May 23, 2024

Mat-moran Dec 15, 2023 •

edited

Loading