Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_credit_control: migrate to V17 #369

Open
wants to merge 134 commits into
base: 17.0
Choose a base branch
from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 15, 2024

No description provided.

@astirpe astirpe mentioned this pull request Mar 15, 2024
10 tasks
@astirpe astirpe marked this pull request as ready for review March 15, 2024 15:43
@astirpe astirpe force-pushed the 17.0_mig_account_credit_control branch from d7297b8 to 468c403 Compare April 3, 2024 15:42
@astirpe astirpe force-pushed the 17.0_mig_account_credit_control branch from ca320c4 to 3488044 Compare April 24, 2024 18:39
@HaraldPanten
Copy link

/ocabot migration account_credit_control

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 20, 2024
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@miquelalzanillas
Copy link

Hello @astirpe , can you please rebase to trigger runbot build for functional review? Thanks

@ and others added 22 commits September 14, 2024 10:35
* Modify scenarios to be compatible with python scenarios
* Voucher/statement related steps
* Deprecated step implementation
* Print report generation
* All tests green
* Mail + print of reminder
* Broken translations
* Fix failure to confirm invoice when both account_credit_control  and account_constraints are installed
* use except_orm instead of except_osv
* reindent code
* Cleanup
* use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed
* Remove 'more info here' from report
* Add some css to reminder report and set texts taking the whole width of the document
* Add a subject in reminder report
* Report use precise mode by default
* date_entry fields on line model to be used by report or in next MP on filter group by
* reporting layer, + add hook function to get contact address
* credit control mail are not in plain text but send as attachement
* policy level name is now translatable as it is use in report and mail
* permission on invoices because onetomany widget load data even if hidden ...
* translation files + lang source
* french translation
* Translation + report invoice address layout
* Label Force credit control policy + french translation
* pep8 (space after comma, reduced length of lines)
* does not need to check if there is ids before calling unlink, it will return early
* remove unused import
* 'raise a new invoice' is a British English expression for 'issue a new invoice'
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP.
* bug 1287072 Level calculation error if previous credit line is ignored
* unifing wizard views to respect UI guide lines
* credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice
* test to ensure that wizard run on customer invoice
* Scenario that test coherence of credit run after manually altering an invoice level
* multicurrency in communication
* ...
* Partner Form view: field "credit_limit" is defined in account module, not base
* Minimal Danish translation
* Do not link e-mails to Transient records

Transient records are deleted periodically so res_id will point to ID which
does not exists. And when reading email records system would also check if
res_id can be read by user which would cause an exception because res_id
might not exist at that point.
This fix seems ugly, but I cant figure why I've a security error when an invoice is  displayed for a user without right on credit_control despite the attribute 'groups' declared on the field definition in the form view
mymage and others added 28 commits September 14, 2024 10:35
Currently translated at 6.7% (19 of 281 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/it/
Currently translated at 6.7% (19 of 281 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/it/
Currently translated at 6.7% (19 of 281 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
Currently translated at 100.0% (282 of 282 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/es/
Currently translated at 80.1% (226 of 282 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/nl/
Currently translated at 80.4% (227 of 282 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
Currently translated at 100.0% (282 of 282 strings)

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/es/
…eporting

This fixes the layout of the 'Credit Control Policy' notebook-page 'Mail and
reporting'.
Several related labels and fields not aligned (not on same line) and also the
translation buttons are invisible.
- Create setUpClass method if necessary
- Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-16.0/credit-control-16.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
The method _generate_emails sets the credit.control.line record(s)
with state 'to_be_sent' to state 'queued' after sending the mail(s),
which is not right.
The state 'queued' is now set (from 'to_be_sent') before sending the
emails!

The mail.mail _postprocess_sent_message method sets the final state to
'sent' or 'error'.
@astirpe astirpe force-pushed the 17.0_mig_account_credit_control branch from 3488044 to 0f81402 Compare September 14, 2024 08:36
@astirpe
Copy link
Member Author

astirpe commented Sep 14, 2024

@miquelalzanillas rebased, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.