-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] account_credit_control: migrate to V17 #369
Open
astirpe
wants to merge
134
commits into
OCA:17.0
Choose a base branch
from
astirpe:17.0_mig_account_credit_control
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astirpe
force-pushed
the
17.0_mig_account_credit_control
branch
from
April 3, 2024 15:42
d7297b8
to
468c403
Compare
astirpe
force-pushed
the
17.0_mig_account_credit_control
branch
from
April 24, 2024 18:39
ca320c4
to
3488044
Compare
/ocabot migration account_credit_control |
bosd
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
Hello @astirpe , can you please rebase to trigger runbot build for functional review? Thanks |
* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations
* Fix failure to confirm invoice when both account_credit_control and account_constraints are installed * use except_orm instead of except_osv * reindent code * Cleanup * use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report
* Report use precise mode by default * date_entry fields on line model to be used by report or in next MP on filter group by * reporting layer, + add hook function to get contact address * credit control mail are not in plain text but send as attachement * policy level name is now translatable as it is use in report and mail * permission on invoices because onetomany widget load data even if hidden ... * translation files + lang source * french translation
* Translation + report invoice address layout * Label Force credit control policy + french translation
…when partners or accounts are duplicated
…e in non draft state before deleting it
* pep8 (space after comma, reduced length of lines) * does not need to check if there is ids before calling unlink, it will return early * remove unused import * 'raise a new invoice' is a British English expression for 'issue a new invoice'
…ranslation extraction
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP. * bug 1287072 Level calculation error if previous credit line is ignored * unifing wizard views to respect UI guide lines * credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice * test to ensure that wizard run on customer invoice * Scenario that test coherence of credit run after manually altering an invoice level * multicurrency in communication * ...
…ding _unported suffix
* Partner Form view: field "credit_limit" is defined in account module, not base * Minimal Danish translation * Do not link e-mails to Transient records Transient records are deleted periodically so res_id will point to ID which does not exists. And when reading email records system would also check if res_id can be read by user which would cause an exception because res_id might not exist at that point.
This fix seems ugly, but I cant figure why I've a security error when an invoice is displayed for a user without right on credit_control despite the attribute 'groups' declared on the field definition in the form view
…ntrol mail template
Currently translated at 6.7% (19 of 281 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/it/
Currently translated at 6.7% (19 of 281 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/it/
Currently translated at 6.7% (19 of 281 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/it/
…ommunication table TT41337
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
Currently translated at 100.0% (282 of 282 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/es/
Currently translated at 80.1% (226 of 282 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/nl/
Currently translated at 80.4% (227 of 282 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
Currently translated at 100.0% (282 of 282 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/es/
…eporting This fixes the layout of the 'Credit Control Policy' notebook-page 'Mail and reporting'. Several related labels and fields not aligned (not on same line) and also the translation buttons are invisible.
- Create setUpClass method if necessary - Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
…rs without "Credit Control/Info" access @moduon MT-4827
The method _generate_emails sets the credit.control.line record(s) with state 'to_be_sent' to state 'queued' after sending the mail(s), which is not right. The state 'queued' is now set (from 'to_be_sent') before sending the emails! The mail.mail _postprocess_sent_message method sets the final state to 'sent' or 'error'.
astirpe
force-pushed
the
17.0_mig_account_credit_control
branch
from
September 14, 2024 08:36
3488044
to
0f81402
Compare
@miquelalzanillas rebased, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.