Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_financial_risk #379

Merged
merged 83 commits into from
May 27, 2024

Conversation

sbiosca-s73
Copy link

Migration module to v17.

The module is migrated in this PR #347, but we have not received a response and we need it the migration correctly.

carlosdauden and others added 30 commits May 22, 2024 16:55
* [9.0][IMP] partner_financial_risk: Improve performance

* [9.0][IMP] partner_financial_risk: Improve tests and partner hierarchy

* [9.0][IMP] partner_stock_risk: Test
- Refunds adds partner risk instead of reduce.
- If date_maturity changes to previous today date "never" compute partner risk.
* [9.0][IMP] partner_financial_risk: Improve multicompany cron

* [9.0][IMP] partner_financial_risk: Exec with sudo

(cherry picked from commit 6590bbf)
Currently translated at 71.2% (52 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/fr/
Currently translated at 79.5% (58 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/it/
Currently translated at 100.0% (73 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es/
Currently translated at 13.7% (10 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es_CL/
Currently translated at 76.7% (56 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt_BR/
Currently translated at 100.0% (73 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt/
…le_financial_risk:

 - Optimize code and change stored computed fields to not store to improve multi-company support
 - Improve multi-currency support
 - Convert risk amount fields to clickable link that shows traceability of amount origin
 - New pivot views to risk amount traceability
 - Simplify class style applied on risk fields
 - Migration script to remove old stored computed fields
 - Improve tests to cover new functionallity
 - Update translation files

account_financial_risk:
 - Don't block refund invoice validation when partner has risk exception
 - Allow search partners by risk exception field
 - Remove obsolete cron

sale_financial_risk
 - Create related store commercial_partner_id field in sale order line to simplify computation
 - Rename amt_to_invoice field to risk_amount in sale order line
 - Hook and migration scripts to reduce new fields computing time

TT23765
This commit adds an specific group for overpassing partner credit limit exceptions
In some situations, not only account managers shoud be allowed to overpass exception, depending on the company policies. Merging this code will not affect current instances, as long as account managers will be added to the new group.
OCA-git-bot and others added 4 commits May 22, 2024 16:55
@pedrobaeza
Copy link
Member

Please check CI.

/ocabot migration account_financial_risk

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 23, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 23, 2024
10 tasks
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig_account_financial_risk branch from 6d95af6 to 9f0a420 Compare May 23, 2024 07:13
@sbiosca-s73
Copy link
Author

@carlosdauden tests correctly

Copy link

@amcorpc amcorpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot OK. LGTM

@pedrobaeza
Copy link
Member

There's a weird commit: 9f0a420

squashing too many commits it seems and clearly with a wrong commit message. Can you please fix it?

@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig_account_financial_risk branch from 9f0a420 to 89905df Compare May 27, 2024 11:43
@sbiosca-s73
Copy link
Author

@pedrobaeza commit message updated

@pedrobaeza
Copy link
Member

I think you should be put as co-author at least (or split into 2 commits), as right now the attribution is to the previous contributor, but he didn't do the hard work.

Co-authored-by: sbiosca-s73 <sergi.biosca@studio73.es>
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig_account_financial_risk branch from 89905df to fcddb80 Compare May 27, 2024 13:20
@sbiosca-s73
Copy link
Author

@pedrobaeza done

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-379-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e163dc9 into OCA:17.0 May 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2549ca1. Thanks a lot for contributing to OCA. ❤️

@ioans73 ioans73 deleted the 17.0-mig_account_financial_risk branch May 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.