Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sale_financial_risk_info: groups to risk_info field #381

Conversation

LuciaMarchalFactorLibre

A user without assigned risk permissions can view the 'Risk Info' field.

image
image

Without having User or Manager permissions, you should not see that field.

@LuciaMarchalFactorLibre LuciaMarchalFactorLibre changed the title UPD sale_financial_risk_info ADD groups risk_info field [16.0][ADD] groups to risk_info field May 23, 2024
Copy link

@flalexg flalexg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LuciaMarchalFactorLibre LuciaMarchalFactorLibre changed the title [16.0][ADD] groups to risk_info field [16.0][IMP] sale_financial_risk_info: groups to risk_info field May 23, 2024
Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the objective of this module is for any salesperson with the minimum permissions to see this information, but not have access to the customer risk info tab.

If you want, you can add a new view with a configuration option that activates one or the other, but without changing the default behavior of the module.

@carlosdauden
Copy link
Contributor

You also have the option to customize the system parameter sale_financial_risk_info.info_pattern so that, for example, it only shows the percentage

@LuciaMarchalFactorLibre
Copy link
Author

You also have the option to customize the system parameter sale_financial_risk_info.info_pattern so that, for example, it only shows the percentage

I've searched that pattern and it doesn't exist

@carlosdauden
Copy link
Contributor

Because we use a default value, but you can create this parameter sale_financial_risk_info.info_pattern to be used here:

info_pattern = ICP.get_param(
"sale_financial_risk_info.info_pattern",
default="<h5{text_class}>{risk_total} / {credit_limit} ("
"{risk_percent}%)</h5>",
)

@carlosdauden
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants