Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_payment_return_financial_risk: Migration to version 17.0 #392

Merged

Conversation

carlos-lopez-tecnativa
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa commented Jul 24, 2024

@carlosdauden
Copy link
Contributor

Can you add account_payment_return repo dependency to tray in runboat?

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-account_payment_return_financial_risk branch from 09e9d1e to a7186a7 Compare July 31, 2024 14:14
@carlos-lopez-tecnativa
Copy link
Author

Can you add account_payment_return repo dependency to tray in runboat?

@carlosdauden done, could you please update review

@carlos-lopez-tecnativa
Copy link
Author

@carolinafernandez-tecnativa @pedrobaeza could you please help me with the review of this module? Thank you!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with this customer with this set up:

image

I created this invoice

image

I registered full payment and i go to create customer payment return for more than limit established

And i could confirm without the control

image

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-account_payment_return_financial_risk branch from a7186a7 to eaa9cce Compare September 2, 2024 15:53
carlosdauden and others added 22 commits September 2, 2024 11:02
OCA Transbot updated translations from Transifex
* [9.0][FIX] partner_financial_risk: Invoice refunds add risk. Date_maturity change

* [9.0][FIX] partner_financial_risk: Recompute when invoice_unpaid_margin change

* [9.0][IMP] partner_financial_risk: Improve heritability

* [9.0][IMP] partner_payment_return_risk: Unify with base method and split amount

* [9.0][IMP] partner_financial_risk: Improve code. Include archived contacts

* [9.0][WIP] partner_financial_risk: Different model in read_group list

* [9.0][WIP] partner_financial_risk: Invoices amount from account.move.line

* [9.0][WIP] partner_financial_risk: Change "©" to Copyright

* [9.0][IMP] partner_financial_risk: invoice_unpaid_margin in depends

* [9.0][IMP] partner_financial_risk: Descriptions and translation

OCA Transbot updated translations from Transifex
[ADD] icon.png

[UPD] Update account_payment_return_financial_risk.pot

[UPD] README.rst
Currently translated at 100.0% (7 of 7 strings)

Translation: credit-control-12.0/credit-control-12.0-account_payment_return_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_payment_return_financial_risk/pt_BR/
…le_financial_risk:

 - Optimize code and change stored computed fields to not store to improve multi-company support
 - Improve multi-currency support
 - Convert risk amount fields to clickable link that shows traceability of amount origin
 - New pivot views to risk amount traceability
 - Simplify class style applied on risk fields
 - Migration script to remove old stored computed fields
 - Improve tests to cover new functionallity
 - Update translation files

account_financial_risk:
 - Don't block refund invoice validation when partner has risk exception
 - Allow search partners by risk exception field
 - Remove obsolete cron

sale_financial_risk
 - Create related store commercial_partner_id field in sale order line to simplify computation
 - Rename amt_to_invoice field to risk_amount in sale order line
 - Hook and migration scripts to reduce new fields computing time

TT23765
[UPD] Update account_payment_return_financial_risk.pot
…n risk_payment_return computed field.

account_payment_return_financial_risk 13.0.1.0.1
TT37270

[UPD] Update account_payment_return_financial_risk.pot

[UPD] README.rst
…puted fields

account_payment_return_financial_risk 15.0.1.0.1

[UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-16.0/credit-control-16.0-account_payment_return_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_payment_return_financial_risk/
Currently translated at 100.0% (7 of 7 strings)

Translation: credit-control-16.0/credit-control-16.0-account_payment_return_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_payment_return_financial_risk/es/
…ment

- Include context keys for avoiding mail operations overhead.
Currently translated at 14.2% (1 of 7 strings)

Translation: credit-control-16.0/credit-control-16.0-account_payment_return_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_payment_return_financial_risk/nl/
Currently translated at 100.0% (7 of 7 strings)

Translation: credit-control-16.0/credit-control-16.0-account_payment_return_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_payment_return_financial_risk/it/
jakobkrabbe and others added 4 commits September 2, 2024 11:02
Currently translated at 100.0% (7 of 7 strings)

Translation: credit-control-16.0/credit-control-16.0-account_payment_return_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_payment_return_financial_risk/sv/
…ax amounts.

The product product.product_product_2 does not have explicit taxes, but after this commit
odoo/odoo@2836416, an error occurs when comparing the expected amount. So, adapt the amount to compare without taxes and create a new product to avoid depending on demo data.
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-account_payment_return_financial_risk branch from eaa9cce to 9754a34 Compare September 2, 2024 16:33
@carlosdauden
Copy link
Contributor

Ready to merge

@carlos-lopez-tecnativa
Copy link
Author

ping @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration account_payment_return_financial_risk

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 9, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-392-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 1a6c3ab into OCA:17.0 Sep 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 13de6bd. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-account_payment_return_financial_risk branch September 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.