Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP]dms: check for same storage #259

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

PicchiSeba
Copy link
Contributor

Check if the storage is changed when both storage_id and parent_id are passed to the write method

@PicchiSeba PicchiSeba marked this pull request as ready for review September 1, 2023 13:05
@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 2, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

dms/models/directory.py Outdated Show resolved Hide resolved
dms/models/directory.py Outdated Show resolved Hide resolved
dms/models/directory.py Outdated Show resolved Hide resolved
@PicchiSeba PicchiSeba marked this pull request as ready for review September 11, 2023 09:00
@PicchiSeba PicchiSeba changed the title [IMP]dms: check for same storage [14.0][IMP]dms: check for same storage Sep 11, 2023
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@pedrobaeza
Copy link
Member

/ocabot merge minor

You can fw-port it to upper versions.

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-259-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 34ac878 into OCA:14.0 Jan 5, 2024
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 097a4ed. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants