-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] donation & donation_base: 6 improvements #124
[14.0][IMP] donation & donation_base: 6 improvements #124
Conversation
15b236b
to
9410ee5
Compare
Hi @alexis-via, |
Hi @alexis-via, Maybe I should have opened an issue to discuss improvements, but I find it convenient to show my suggestions in code. Below is a short explanation of the commits.
What do you think? |
@alexis-via I added contact filters to search for contacts who need a donation thanks or a tax receipt. This is needed when the documents are sent together with a newsletter. I can create a new module e.g. |
* New Tax Receipt (tax_receipt_send) * New Donation (donation_send_thanks) We send these documents together with a newsletter. So we need to filter contacts with newsletter AND (not) extra document.
2f75062
to
224b3b3
Compare
bcea71d
to
12a7d6c
Compare
I have implemented this into two new modules:
Pull request for 16.0 will come later. |
No description provided.