Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] helpdesk_mgmt: tags - visual and functional adjustments #478

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[15.0][IMP] helpdesk_mgmt: tags - visual and functional adjustments #478

merged 1 commit into from
Jul 4, 2023

Conversation

dalonsod
Copy link
Contributor

@dalonsod dalonsod commented Jun 29, 2023 •
edited
Loading

Included in this PR:

  • Tickets tree: added tags, as optional field.
  • Tickets search view: added tags grouping functionality.
  • Tickets form: usage of tag colors.
  • Tags form: replaced old archive/active button by ribbon.
  • Tags view: added active field.

@dalonsod
[IMP] helpdesk_mgmt: tags - visual and functional adjustments
1fa472a 
Included in this commit:
* Tickets tree: added tags, as optional field.
* Tickets search view: added tags grouping functionality.
* Tickets form: usage of tag colors.
* Tags form: replaced old archive/active button with ribbon.
* Tags view: added active field.
@dalonsod
Copy link
Contributor Author

@rmorant @SergiCForgeFlow could you review? Thanks!

rmorant
rmorant reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@rmorant rmorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checked ok. Just, about "Archived" filter. Forgot it or not necessary?

@dalonsod
Copy link
Contributor Author

dalonsod commented Jun 29, 2023 •
edited
Loading

"Archive" filter already exists... are you talking about "Active" filter instead? I could add it as well.

@rmorant
Copy link
Contributor

rmorant commented Jun 29, 2023

I mean, a quick show of archived tickets
Like "Project > Tasks > Filters > 'Archived' ".

@dalonsod
Copy link
Contributor Author

OK... this PR is all about tags improvements/missing features. Anyway, this could be added in other PR

@SergiCForgeFlow
Copy link
Contributor

LGTM @dalonsod

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dalonsod
Copy link
Contributor Author

dalonsod commented Jul 4, 2023

@pedrobaeza is this PR ready to be merged? Once done, I'll port it to v16

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 4, 2023
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-478-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 10dde39 into OCA:15.0 Jul 4, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b96d31a. Thanks a lot for contributing to OCA. ❤️

@dalonsod dalonsod mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorant rmorant rmorant approved these changes

@SergiCForgeFlow SergiCForgeFlow SergiCForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dalonsod @rmorant @SergiCForgeFlow @OCA-git-bot @pedrobaeza