-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] helpdesk_mgmt: Add empty option to Team and Category fields to portal ticket form #509
[15.0][IMP] helpdesk_mgmt: Add empty option to Team and Category fields to portal ticket form #509
Conversation
This should go along with a configuration to force required or not those data. |
Added changes to set fields as required or not, do you think this is the right approach? |
747669e
to
da0fc18
Compare
da0fc18
to
e0f1cc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 👍
…portal ticket form TT45297
e0f1cc1
to
1685390
Compare
Ping @pedrobaeza |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new required should be True by default, as it's the most similar to the previous one (where you should always select one).
Added configuration to SET the Category and Team fields of the portal form as required. TT45297
1685390
to
8b90ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 6300fbd. Thanks a lot for contributing to OCA. ❤️ |
Changes done:
Before
After
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT45297