Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] helpdesk_mgmt: Add empty option to Team and Category fields to portal ticket form #509

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Sep 28, 2023

Changes done:

  • Add empty option to Team and Category fields to portal ticket form.
  • Add settings to define required fields (Category and Team)

Before
antes

After
despues

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT45297

@pedrobaeza
Copy link
Member

This should go along with a configuration to force required or not those data.

@victoralmau
Copy link
Member Author

Added changes to set fields as required or not, do you think this is the right approach?

@victoralmau victoralmau marked this pull request as ready for review October 2, 2023 06:42
@victoralmau victoralmau force-pushed the 15.0-imp-helpdesk_mgmt-TT45297 branch from 747669e to da0fc18 Compare October 3, 2023 06:47
@victoralmau victoralmau force-pushed the 15.0-imp-helpdesk_mgmt-TT45297 branch from da0fc18 to e0f1cc1 Compare October 3, 2023 07:52
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 👍

@victoralmau victoralmau force-pushed the 15.0-imp-helpdesk_mgmt-TT45297 branch from e0f1cc1 to 1685390 Compare October 3, 2023 11:09
@victoralmau
Copy link
Member Author

Ping @pedrobaeza

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 3, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new required should be True by default, as it's the most similar to the previous one (where you should always select one).

Added configuration to SET the Category and Team fields of the portal form as required.

TT45297
@victoralmau victoralmau force-pushed the 15.0-imp-helpdesk_mgmt-TT45297 branch from 1685390 to 8b90ad1 Compare October 3, 2023 14:09
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-509-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa2bd24 into OCA:15.0 Oct 4, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6300fbd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants