Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] helpdesk_mgmt_project: Set by default the company as the project one in tickets #548

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] helpdesk_mgmt_project: Set by default the company as the project one in tickets #548

wants to merge 1 commit into from

Conversation

vincent-hatakeyama
Copy link
Contributor

No description provided.

@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch 5 times, most recently from ed197d2 to 52fa80f Compare February 29, 2024 12:39
@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch from 52fa80f to 1c22045 Compare March 27, 2024 17:07
@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch 2 times, most recently from 8b66fdd to 9e8ca3b Compare April 16, 2024 10:25
@vincent-hatakeyama vincent-hatakeyama changed the title [16.0][ADD] helpdesk_mgmt_project: Set by default the company as the project one in tickets [16.0][IMP] helpdesk_mgmt_project: Set by default the company as the project one in tickets Apr 16, 2024
@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch from 9e8ca3b to acc1fc0 Compare May 17, 2024 09:52
flotho
flotho approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@flotho
Copy link
Member

flotho commented Jul 1, 2024

Hi @vincent-hatakeyama , any chance to rebase ?

@flotho flotho mentioned this pull request Jul 1, 2024
Closed
@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch from acc1fc0 to c9d815f Compare July 2, 2024 13:59
@vincent-hatakeyama
Copy link
Contributor Author

Hi @vincent-hatakeyama , any chance to rebase ?

Done.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 3, 2024
@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch from c9d815f to 921686d Compare November 4, 2024 08:02
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
@flotho
Copy link
Member

flotho commented Dec 18, 2024

Hi @vincent-hatakeyama , any chance to rebase or push a smal change to reset the CI ?

@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-helpdesk_mgmt_project-add-ticket-default-company branch from 921686d to dc251e3 Compare December 18, 2024 15:39
@vincent-hatakeyama
Copy link
Contributor Author

Hi @vincent-hatakeyama , any chance to rebase or push a smal change to reset the CI ?

Just rebased on latest 16.0

flotho
flotho reviewed Dec 19, 2024
View reviewed changes
helpdesk_mgmt_project/views/helpdesk_ticket_view.xml
@@ -33,6 +33,11 @@
<field name="inherit_id" ref="helpdesk_mgmt.ticket_view_form" />
<field name="arch" type="xml">
<xpath expr="//field[@name='partner_email']" position="after">
<field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for this PR, could you explain the use of this ?
AFAICR, either the field is not pushed in the view if you're not in the group and if you're member of the gourp, it's invisible.
my conclusion is that you never display nor use the field.
Tanks for your next precisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent-hatakeyama @flotho @aronabencherif