Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] helpdesk_mgmt_template: add module #614

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] helpdesk_mgmt_template: add module #614

wants to merge 1 commit into from

Conversation

dessanhemrayev
Copy link

The module adds the following features:

  • Pre-configure ticket description template based on it's category

@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch 5 times, most recently from 9217aa0 to 9392f29 Compare August 5, 2024 22:23
Bearnard21
Bearnard21 approved these changes Aug 9, 2024
View reviewed changes
Copy link

@Bearnard21 Bearnard21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch 2 times, most recently from d6633fe to 32608c2 Compare August 9, 2024 22:11
@GabbasovDinar
Copy link
Member

Code LGTM.

@dessanhemrayev Please rename module:

helpdesk_mgmt_templates -> helpdesk_mgmt_template

@dessanhemrayev dessanhemrayev changed the title [16.0][ADD] helpdesk_mgmt_templates: add module [16.0][ADD] helpdesk_mgmt_template: add module Aug 12, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Bearnard21
Copy link

@rvalyi, would you be so kind as to check the PR and merge it to see if it's okay? Thank you.

@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 9df81fa to 695c752 Compare August 13, 2024 19:50
@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 695c752 to 2345645 Compare August 21, 2024 18:41
@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 900cfcd to d3a15d7 Compare August 31, 2024 16:19
@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 78d1071 to 2345645 Compare September 17, 2024 20:25
badbole added a commit to dajmi5/icrc that referenced this pull request Oct 1, 2024
@badbole
tmp commit borrowed from : OCA/helpdesk#614
76201d8
@OCA-git-bot
Copy link
Contributor

Sorry @Bearnard21 you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 96cf82e to 988b421 Compare October 14, 2024 19:11
hoangtrann
hoangtrann reviewed Oct 20, 2024
View reviewed changes
helpdesk_mgmt_template/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
helpdesk_mgmt_template/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt_template/models/helpdesk_ticket.py Outdated
Comment on lines 36 to 39
def _inverse_description(self):
for record in self:
description = record.description
record.description = description
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting store=True and readonly=False is enough to compute and allow edit on this field, is this necessary?

Copy link
Author

@dessanhemrayev dessanhemrayev Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review)
I fixed it, accepted your suggestions and merged all the commits, sorry.

@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 6ebe4a6 to ac1005c Compare October 21, 2024 19:11
hoangtrann
hoangtrann approved these changes Oct 22, 2024
View reviewed changes
Copy link

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from ac1005c to aefb026 Compare October 23, 2024 20:31
@ivs-cetmix ivs-cetmix force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 6d7c863 to bddeae1 Compare November 29, 2024 19:45
@ivs-cetmix
Copy link
Member

Hey @OCA/helpdesk-maintainers would be great to have this reviewed and merge if it's fine. Let's make the OCA helpdesk more flexible!)

@dessanhemrayev
[ADD] helpdesk_mgmt_template: add module
0533a1e 
This module adds pre-configured ticket description templates based on category

This commit introduces the following enhancements:
- Adds the ability to pre-configure a helpdesk ticket's description template based on the selected category.
- Users can now define ticket description templates within Helpdesk-->Configuration-->Categories.
- Categories can be assigned to specific teams, allowing pre-defined templates to be triggered during ticket creation.

Task: 3829
@dessanhemrayev dessanhemrayev force-pushed the 16.0-t3829-helpdesk_mgmt_templates branch from 320f777 to 0533a1e Compare December 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bearnard21 Bearnard21 Bearnard21 approved these changes

@hoangtrann hoangtrann hoangtrann approved these changes

@GabbasovDinar GabbasovDinar GabbasovDinar approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dessanhemrayev @GabbasovDinar @OCA-git-bot @Bearnard21 @ivs-cetmix @hoangtrann