[16.0][ADD] helpdesk_ticket_partner_response: New module helpdesk_ticket_partner_response #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peluko00
force-pushed
the
16.0-add-helpdesk_ticket_customer_response
branch
5 times, most recently
from
812cfe5 to
2d13efd
Compare
miquelalzanillas
suggested changes
Jan 2, 2025
|
|
||
| |maintainer-peluko00| | ||
|
|
||
| This module is part of the `OCA/helpdesk <https://github.com/OCA/helpdesk/tree/16.0/helpdesk_ticket_customer_response>`_ project on GitHub. |
There was a problem hiding this comment.
I think you should replace all references from 'customer' to 'partner' on module name, files and fields as the module can be useful in more cases where any customer is involved.
Comment on lines
10
to
13
| change_customer_reponse_stage_tickets = fields.Boolean( | ||
| string="Automatic change stage of tickets answered by customer", | ||
| default=False, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| change_customer_reponse_stage_tickets = fields.Boolean( | |
| string="Automatic change stage of tickets answered by customer", | |
| default=False, | |
| ) | |
| autoupdate_ticket_stage = fields.Boolean( | |
| string="Auto Update Ticket Stage", help="Update ticket stage when a new message is registered by the partner." | |
| default=False, | |
| ) |
I think would be better adding the context on 'help' parameter and get a shorter field name. What you think?
helpdesk_ticket_customer_response/models/helpdesk_ticket_team.py
Outdated
Show resolved
Hide resolved
miquelalzanillas
suggested changes
Jan 2, 2025
peluko00
force-pushed
the
16.0-add-helpdesk_ticket_customer_response
branch
2 times, most recently
from
826bde6 to
9f28f2a
Compare
|
Thanks for your feedback @miquelalzanillas, i'm completly in agreement with you. Can you review again? |
peluko00
changed the title
miquelalzanillas
suggested changes
Jan 2, 2025
helpdesk_ticket_partner_response/views/helpdesk_ticket_team.xml
Outdated
Show resolved
Hide resolved
peluko00
changed the title
…cket_customer_response
peluko00
force-pushed
the
16.0-add-helpdesk_ticket_customer_response
branch
from
9f28f2a to
1525563
Compare
miquelalzanillas
approved these changes
Jan 2, 2025
|
Can you review please @pedrobaeza ? |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6ed1ac0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module change ticket stage when customer answered the ticket from portal or mail.
cc https://github.com/APSL 165161
@miquelalzanillas @BernatObrador @ppyczko please review