Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_th_multicurrency_revaluation #416

Open
wants to merge 5 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] l10n_th_multicurrency_revaluation #416

wants to merge 5 commits into from

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Nov 28, 2023 •
edited
Loading

This PR fixed from OCA/account-closing#263

  • Add type credit card can revalue
  • Change analytic to distribution analytic following core odoo16

cherry-pick from #437

@Saran440
Copy link
Member Author

/ocabot migration

@OCA-git-bot
Copy link
Contributor

Hi @Saran440. Your command failed:

Invalid options for command migration: .

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@Saran440
Copy link
Member Author

/ocabot migration l10n_th_multicurrency_revaluation

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 29, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 29, 2024
Open
20 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@Saran440 Saran440 removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 10, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
@Saran440 Saran440 removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 11, 2024
ps-tubtim and others added 5 commits November 13, 2024 14:52
@ps-tubtim
[15.0][ADD] l10n_th_multicurrency_revaluation
457776c
[UPD] Update l10n_th_multicurrency_revaluation.pot
434ac33
@Saran440
[IMP] l10n_th_multicurrency_revaluation: pre-commit stuff
49c4a31
@Saran440
[MIG] l10n_th_multicurrency_revaluation: Migration to 16.0
c42b372
[FIX] l10n_th_multicurrency_revaluation: Corrected journal entry amou…
155991a 
…nts for partial payment revaluations.

This fix where the debit and credit amounts on journal entries were incorrect when performing currency revaluations on partially paid invoices.

Step to test:
1. On 01/01/2024, a vendor bill was issued for 100 CNY at a rate of 1 CNY = 5 THB.
2. A payment of 40 CNY was recorded on the same day at the same rate.
3. A currency revaluation was conducted on 31/01/2024, with the rate adjusted to 1 CNY = 4.30 THB.
4. The journal entry incorrectly reflected an exchange rate difference of 70, calculated as 100 x 5 - 100 x 4.30 (instead of the correct amount, 42 CNY, calculated as (100 - 40) x 5 - (100 - 40) x 4.30).
@Saran440 Saran440 force-pushed the 16.0-mig-l10n_th_multicurrency_revaluation branch from 885ef06 to 155991a Compare November 13, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Saran440 @OCA-git-bot @ps-tubtim