Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support copier 9 #221

Merged
merged 1 commit into from
Oct 31, 2023
Merged

build: support copier 9 #221

merged 1 commit into from
Oct 31, 2023

Conversation

yajo
Copy link
Member

@yajo yajo commented Oct 31, 2023

No description provided.

@yajo yajo requested a review from sbidoul October 31, 2023 08:46
@yajo yajo self-assigned this Oct 31, 2023
@yajo yajo added the dependencies Pull requests that update a dependency file label Oct 31, 2023
comment_start_string: "{#"
keep_trailing_newline: true
variable_end_string: "}}"
variable_start_string: "{{"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yajo does this mean the default jinja syntax changed with copier 9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changed many versions ago. We just didn't have a constraint, so we had to define it manually.

@yajo yajo merged commit 1e6e78b into OCA:master Oct 31, 2023
7 checks passed
@yajo yajo deleted the copier9 branch October 31, 2023 09:00
@pedrobaeza
Copy link
Member

Why forcing the latest version and why each version is incompatible with the previous?

@yajo
Copy link
Member Author

yajo commented Oct 31, 2023

There are a few fixes for default and when in recent versions. I can't remember in which one there were some bugs fixed, but anyway it seems sane to bump to latest.

Copier is detached from the template, so ensuring a minimal version is used means more predictable replayability.

Regarding incompatibilities, you can see the changelog.

@pedrobaeza
Copy link
Member

My fear here is that copier won't run in its latest version in all current development environments. Is it working for current + previous LTS versions of popular distros?

@yajo
Copy link
Member Author

yajo commented Oct 31, 2023

AFAIK no popular distro packages copier.

@pedrobaeza
Copy link
Member

I mean the dependencies for making copier to run. If copier now depends on the library X version N that is incompatible/not found in for example Ubuntu 22.04, it's a big problem.

@yajo
Copy link
Member Author

yajo commented Oct 31, 2023

If you install copier with pipx or nix, it won't be a problem.

@pedrobaeza
Copy link
Member

OK, good to know. I'll write back if any problem found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants