[14.0][ADD] partner_kind #1531

syera94 · 2023-05-31T11:52:07Z

Here the partner_kind module to be able to select a type de partner.

Kev-Roche

Good job!
Please rename the PR with the version number : [14.0][ADD] partner_kind
And add the readme authors part with you and @sebastienbeau in it.

Kev-Roche · 2023-06-15T13:50:01Z

partner_kind/i18n/fr.po

+#: model_terms:ir.ui.view,arch_db:partner_kind.view_partner_form
+#: model_terms:ir.ui.view,arch_db:partner_kind.view_res_partner_filter
+msgid "kind"
+msgstr "Type"


The French translation need to be updated (for exemple "Individual", "Company")

we ll do together

Kev-Roche · 2023-06-15T13:50:33Z

partner_kind/models/res_partner.py

+            ("company", "Company"),
+        ]
+
+    @api.depends("user_ids", "parent_id", "company_type")


Suggested change

@api.depends("user_ids", "parent_id", "company_type")

@api.depends("user_ids", "parent_id", "is_company")

Kev-Roche · 2023-06-15T13:54:58Z

partner_kind/models/res_partner.py

+    def _compute_kind(self):
+
+        for rec in self.with_context(active_test=False):
+            if rec.user_ids:


With context active_test=False, the kind of an active partner will stay as "user" even if the related res.user was archived.
I recommend the following:

Suggested change

def _compute_kind(self):

for rec in self.with_context(active_test=False):

if rec.user_ids:

def _compute_kind(self):

for rec in self:

if any(rec.user_ids.mapped("active")):

also add "user_ids.active" in @api.depends

we need both user_ids and user_ids.active

Kev-Roche · 2023-06-15T13:55:57Z

partner_kind/models/res_partner.py

+                rec.kind = "user"
+            elif rec.parent_id:
+                rec.kind = "address"
+            elif rec.is_company is True:


Suggested change

elif rec.is_company is True:

elif rec.is_company:

Kev-Roche · 2023-06-15T13:56:16Z

partner_kind/models/res_partner.py

+            elif rec.is_company is True:
+                if not rec.parent_id:
+                    rec.kind = "company"
+            elif rec.is_company is False:


Suggested change

elif rec.is_company is False:

elif not rec.is_company:

Kev-Roche · 2023-06-15T13:57:22Z

partner_kind/models/res_partner.py

+        for rec in self.with_context(active_test=False):
+            if rec.kind == "user" and not rec.user_ids:


Suggested change

for rec in self.with_context(active_test=False):

if rec.kind == "user" and not rec.user_ids:

for rec in self:

if rec.kind == "user" and not any(rec.user_ids.mapped("active")):

Kev-Roche · 2023-06-15T13:58:50Z

partner_kind/models/res_partner.py

+            elif rec.parent_id:
+                rec.kind = "address"
+            elif rec.is_company is True:
+                if not rec.parent_id:


Suggested change

if not rec.parent_id:

also tested above

Kev-Roche · 2023-06-15T14:01:56Z

partner_kind/readme/DESCRIPTION.rst

+- The recordset address : for the company or person linked to a parent
+- the recordset user : for company internal person which cannot be concerned by the kind
+- the recordset company : for the other case if it's a company
+- the recordset person : as the field is required, there is a default value


They are not recordset, just selection options, please change it in all the readme.
Maybe " - Address : for the company or person linked to a parent" is enough.
Also, you can use the interface term for users.

Kev-Roche · 2023-06-15T14:04:10Z

partner_kind/tests/test_partner_kind.py

+        self.Partner4 = self.env["res.partner"].create(
+            {
+                "name": "Test",
+                "company_type": "person",


Not required as it's the default kind.

only line 18 "company_type": "person", was unnecessary, you have to keep self.Partner4 and the related test.

Kev-Roche · 2023-06-15T14:27:39Z

partner_kind/models/res_partner.py

+                if not rec.parent_id:
+                    rec.kind = "company"
+            elif rec.is_company is False:
+                if not rec.user_ids:


Suggested change

if not rec.user_ids:

Already tested above

Kev-Roche · 2023-06-19T10:06:23Z

partner_kind/readme/DESCRIPTION.rst

+The way to use this module:
+
+In the method _get_partner_kind, add the selection you need as partner kind.
+Once is done,if you want to remove all of the initial recordset, you can also remove the compute field or change it to fit better to your case
+if you only want to remove some of the initial recordset, you have to remove in the compute field the linked conditions
+After, the same thing as to be done in a contrains.
+
+For the tests, as they are linked to this specifiques initials recordsets, thet won't worked if you remove or change this initial recordsets.


Duplicate of USAGE.srt.
I'm not sure but I think that the readme needs to describe the module itself, not the potential changes that we can do on it.

Kev-Roche · 2023-06-19T10:06:35Z

partner_kind/readme/DESCRIPTION.rst

@@ -0,0 +1,16 @@
+This module add kind of partner to partners.


Check the typos on the file

sebastienbeau · 2023-06-20T07:47:36Z

partner_kind/models/res_partner.py

+    def _compute_kind(self):
+
+        for rec in self:
+            if rec.kind == "user" and not any(rec.user_ids.mapped("active")):


for res in self: rec._get_default_kind()

sebastienbeau · 2023-06-20T08:15:50Z

partner_kind/models/res_partner.py

+class ResPartner(models.Model):
+
+    _inherit = ["res.partner"]
+


In the view hide the field "company_type"

is_company = fields.Boolean( compute="_compute_is_company", compute_sudo=True, store=True, ) def _get_is_company_kind(self): return ["company"] @api.depends("kind") def _compute_is_company(self): for record in self: record.is_company = record.kind in self._get_is_company_kind()

sebastienbeau · 2023-06-20T08:31:57Z

partner_kind/models/res_partner.py

+            elif rec.is_company:
+                rec.kind = "company"
+            elif not rec.is_company:
+                rec.kind = "person"


we can remove it if the is_company is a computed field ;)

syera94 · 2023-06-23T10:02:56Z

@Kev-Roche : the changes which has been modified since our conversation this morning (23/06/2023) --> as the field parent_id is linked to the field company_type, if i hide it, the field parent_id does not appear anymore.
In my opinion, it's better to let it visible.
Check and see
@sebastienbeau FYI

github-actions · 2023-10-29T12:30:09Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

syera94 force-pushed the partner_kind branch from 93ed4ea to c1b6bbb Compare May 31, 2023 12:19

Kev-Roche suggested changes Jun 15, 2023

View reviewed changes

Kev-Roche reviewed Jun 15, 2023

View reviewed changes

syera94 changed the title ~~[ADD] partner_kind~~ [14.0][ADD] partner_kind Jun 16, 2023

Kev-Roche suggested changes Jun 19, 2023

View reviewed changes

sebastienbeau reviewed Jun 20, 2023

View reviewed changes

syera94 force-pushed the partner_kind branch 2 times, most recently from e7109a7 to 549cdda Compare June 22, 2023 10:05

[ADD][14.0] partner_kind

da9de5e

syera94 force-pushed the partner_kind branch from ebc48f4 to da9de5e Compare June 23, 2023 09:49

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023

github-actions bot closed this Dec 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] partner_kind #1531

[14.0][ADD] partner_kind #1531

syera94 commented May 31, 2023

Kev-Roche left a comment

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 15, 2023 •

edited

Loading

syera94 Jun 16, 2023

Kev-Roche Jun 19, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 15, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 19, 2023

Kev-Roche Jun 15, 2023

syera94 Jun 16, 2023

Kev-Roche Jun 19, 2023

Kev-Roche Jun 19, 2023

sebastienbeau Jun 20, 2023

sebastienbeau Jun 20, 2023

sebastienbeau Jun 20, 2023

syera94 commented Jun 23, 2023

github-actions bot commented Oct 29, 2023

	@api.depends("user_ids", "parent_id", "company_type")
	@api.depends("user_ids", "parent_id", "is_company")

		for rec in self.with_context(active_test=False):
		if rec.kind == "user" and not rec.user_ids:

		@@ -0,0 +1,16 @@
		This module add kind of partner to partners.

[14.0][ADD] partner_kind #1531

[14.0][ADD] partner_kind #1531

Conversation

syera94 commented May 31, 2023

Kev-Roche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kev-Roche Jun 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syera94 commented Jun 23, 2023

github-actions bot commented Oct 29, 2023

Kev-Roche Jun 15, 2023 •

edited

Loading