[16.0] Replace partner_address_two_lines by partner_display_name_line_break

[JuMiSanAr]

Fix the separation in two lines, and add tests.

Depends on: odoo/odoo#126451

[grindtildeath]

For the test, please focus on writing a "unit" test by calling name_get on different partners structures. We just want to make sure we get a \n instead of a , and that we don't get the separator and the contact type in case there's no contact name.

[mmequignon]

would be nice to have a screenshot or smth…
LG tough.

[rafaelbn]

We have to change the module name please! 🙏🏼 😄 ❤️

It's really confusing :-(

The module make this:

[rafaelbn]

@rousseldenis which name in your head?

[NL66278]

Leave out the blank after \n . Same goes for the invoice address.

The improved code does not add a space at the beginning of the second line, which in my opinion is correct. The old code did however.

[trisdoan]

Hi @rafaelbn, do you still want to rename the module

I am migrating it to 17.0. I can rename it as a part of the migration

[rafaelbn]

@NL66278 @JuMiSanAr is this still need fixing PR?

Any idea with module name @hbrunn ?

partner_display_name_break_line ?

Thank you! 😄

Remember @trisdoan , this PR depends in a Odoo/odoo PR too

[rafaelbn]

/ocabot rebase

[OCA-git-bot]

@rafaelbn The rebase process failed, because command git push --force camptocamp tmp-pr-1546:16.0--partner_address_two_lines--fix failed with output:

remote: Permission to camptocamp/partner-contact.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/camptocamp/partner-contact/': The requested URL returned error: 403

[NL66278]

@rafaelbn My comment on how to fix the failing test has not been taken up after half a year. The prerequisite Odoo PR has a merge conflict that is also not resolved. If nothing is done on these issues I would propose closing the PR.

[JuMiSanAr]

Test updated. Regarding the module name, I'm open to suggestions.

[rafaelbn]

@NL66278 right! Test are fixed now! 🥳

[NL66278]

@JuMiSanAr I have two more request for approval and merge:

• Squash your commits, so we are left with one commit;
• Rename the module to partner_display_name_line_break;

Nearly the same as the module name proposed by @rafaelbn , but I think "line break" is the recognized term for this.

[rafaelbn]

I agree El mié, 24 abr 2024, 10:14, Ronald Portier ***@***.***> escribió:

…

@JuMiSanAr <https://github.com/JuMiSanAr> I have two more request for approval and merge: - Squash your commits, so we are left with one commit; - Rename the module to partner_display_name_line_break; Nearly the same as the module name proposed by @rafaelbn <https://github.com/rafaelbn> , but I think "line break" is the recognized term for this. — Reply to this email directly, view it on GitHub <#1546 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCU63ZGTW2AKKQ6CZLDBP3Y65SV5AVCNFSM6AAAAAAZP5V3Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZUGM2TAMJZHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JuMiSanAr]

@JuMiSanAr I have two more request for approval and merge:

• Squash your commits, so we are left with one commit;
• Rename the module to partner_display_name_line_break;

Nearly the same as the module name proposed by @rafaelbn , but I think "line break" is the recognized term for this.

There you go ☺️

[NL66278]

👍 LGTM. Thanks for your contribution. Two questions, not breaking::

• Why the dependency on context key? If this module is installed, apparently the instance administrators want to display the name and the company on two lines.
• Does this really depend on the Odoo PR? If the Odoo PR is not accepted or merged, you will also get possibly the word 'Invoice' or one of the other type descriptions on a separate line. To me this seems to be consistent with the partner name on a second line.

[rafaelbn]

Thank you! 👍🏼

NL66278 approved these changes

👍 LGTM. Thanks for your contribution. Two questions, not breaking::

• Why the dependency on context key? If this module is installed, apparently the instance administrators want to display the name and the company on two lines.
• Does this really depend on the Odoo PR? If the Odoo PR is not accepted or merged, you will also get possibly the word 'Invoice' or one of the other type descriptions on a separate line. To me this seems to be consistent with the partner name on a second line.

[trisdoan]

Hello @@JuMiSanAr, LGTM.

I agree with NL66278 that it does not need to depend on that PR

[NL66278]

/ocabot merge minor

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1546-by-NL66278-bump-minor, awaiting test results.

[OCA-git-bot]

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1546-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[hbrunn]

please also add a PR to https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/apriori.py#L6 to document the renaming for openupgrade.

/ocabot merge minor

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1546-by-hbrunn-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1ccae3b. Thanks a lot for contributing to OCA. ❤️